This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Add yolo mode to rustfix #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
master
branch
2 times, most recently
from
22f2ef0 to
68a18ab
Compare
killercup
suggested changes
May 15, 2017
src/main.rs
Outdated
| @@ -92,7 +95,7 @@ fn get_json(extra_args: &[&str]) -> Result<String, ProgramError> { | |||
| Ok(String::from_utf8(output.stdout)?) | |||
| } | |||
|
|
|||
| fn handle_suggestions(suggestions: &[Suggestion]) -> Result<(), ProgramError> { | |||
| fn handle_suggestions(suggestions: &[Suggestion], yolo: bool) -> Result<(), ProgramError> { | |||
There was a problem hiding this comment.
Nope, this is not how we do things. There needs to be an enum Assertiveness { BetterSafeThanSorry, Yolo } instead of a boring bool! 
|
I'm really confused about how travis works... |
killercup
reviewed
May 15, 2017
| #[derive(PartialEq, Eq, Debug)] | ||
| enum AutofixMode { | ||
| /// Do not apply any fixes automatically | ||
| None, |
There was a problem hiding this comment.
But… but… it took me minutes to come up with BetterSafeThanSorry 😿
Okay… fine. Have it your way.
travis.sh
Outdated
| cargo build | ||
| if [ "$TRAVIS_RUST_VERSION" == "nightly" ]; then | ||
| cargo test -- --nocapture | ||
| fi |
There was a problem hiding this comment.
Can you embed that in .travis.yml? I don't think these 4 lines need to be in their own file
Err, you probably need to start that file with script:
- |
cargo build &&
if [[ "$TRAVIS_RUST_VERSION" == nightly* ]]; then
cargo test -- --nocapture
fi |
killercup
approved these changes
May 15, 2017
|
Feel free to merge, and maybe squash the travis struggle commits if you want |
… since they need clippy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.