Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Update to serde 1.0 #21

Merged
merged 1 commit into from
May 10, 2017
Merged

Update to serde 1.0 #21

merged 1 commit into from
May 10, 2017

Conversation

oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented May 10, 2017

rustfix compiles on stable now...

@killercup
Copy link
Member

Woah :O And it still works with rustc's JSON output?

@oli-obk
Copy link
Collaborator Author

oli-obk commented May 10, 2017

trying that right now... the json output should be stable anyway...

@killercup killercup merged commit 4e73be6 into rust-lang:master May 10, 2017
@killercup
Copy link
Member

Cool, let me know if it explodes :)

@oli-obk
Copy link
Collaborator Author

oli-obk commented May 10, 2017

it does ^^ looking now what's going on

@oli-obk
Copy link
Collaborator Author

oli-obk commented May 10, 2017

I think it's because cargo clippy returns an error exit code whenever it encounters something to report.

@oli-obk
Copy link
Collaborator Author

oli-obk commented May 10, 2017

ah that was it. And already found a bug in clippy:

Info: use of `unwrap_or` followed by a function call
  --> tests/compiletest.rs:135:39-135:76
Suggestion - Replace:

    let end = text.find('\n').unwrap_or(text.len());

with:

    text.find('\n').unwrap_or_else(|| text.len())

Edit: nevermind, just rustfix displaying only part of what's going on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants