This repository was archived by the owner on Nov 24, 2023. It is now read-only.
replace serde_macros by serde_derive #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde_macros is being deprecated in favor of serde_derive[0].
As a result, rustfix does not build on nighlty anymore[1].
This commit replaces serde_macros by serde_derive.
[0]
https://users.rust-lang.org/t/serde-transitioning-to-macros-1-1/7437/5
[1] serde-rs/serde#606 (comment)
Unfortunately, this is not enough:
I dont' get this error because
rustfix::diagnostics::Diagnostic
does deriveDeserialize
: https://github.com/killercup/rustfix/blob/master/src/diagnostics.rs#L5Feel free to close in favor of a working PR, otherwise, I'll try to finish this tonight.