Speed up compilation by 23% #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, serde_derive is built before serde. But serde does
not depend on serde_derive, so that is not needed. Instead, build serde
and serde_derive in parallel. That speeds up compilation by 23%.
Before:
$ hyperfine --prepare 'cargo clean' 'cargo build'
Benchmark 1: cargo build
Time (mean ± σ): 4.979 s ± 0.044 s [User: 4.887 s, System: 0.714 s]
Range (min … max): 4.915 s … 5.068 s 10 runs
After:
$ hyperfine --prepare 'cargo clean' 'cargo build'
Benchmark 1: cargo build
Time (mean ± σ): 3.821 s ± 0.065 s [User: 5.083 s, System: 0.740 s]
Range (min … max): 3.749 s … 3.955 s 10 runs
GuillaumeGomez
approved these changes
Jun 3, 2025
|
Thanks! |
|
This will get blown away the next time Also, we should use triagebot to add a comment for all PR's that touch |
|
Thanks. For the record, there used to be a version mismatch problem to do this split up, but that was fixed over a year ago. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 5, 2025
…umeGomez rustdoc-json-type: Depend on `serde` and `serde_derive` seperately Before this commit, serde_derive is built before serde. But serde does not depend on serde_derive, so that is not needed. Instead, build serde and serde_derive in parallel. This speeds up compilation for users depending on rustdoc-json-types out of tree. Imports: rust-lang/rustdoc-types#49 CC `@Enselic` r? `@GuillaumeGomez`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 5, 2025
…umeGomez rustdoc-json-type: Depend on `serde` and `serde_derive` seperately Before this commit, serde_derive is built before serde. But serde does not depend on serde_derive, so that is not needed. Instead, build serde and serde_derive in parallel. This speeds up compilation for users depending on rustdoc-json-types out of tree. Imports: rust-lang/rustdoc-types#49 CC ``@Enselic`` r? ``@GuillaumeGomez``
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 5, 2025
Rollup merge of #141989 - aDotInTheVoid:sin-sooner, r=GuillaumeGomez rustdoc-json-type: Depend on `serde` and `serde_derive` seperately Before this commit, serde_derive is built before serde. But serde does not depend on serde_derive, so that is not needed. Instead, build serde and serde_derive in parallel. This speeds up compilation for users depending on rustdoc-json-types out of tree. Imports: rust-lang/rustdoc-types#49 CC ``@Enselic`` r? ``@GuillaumeGomez``
|
Published as d7f859a (0.46.1), which also specifies that we need serde to be at least 1.0.186 |
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jun 6, 2025
rustdoc-json-type: Depend on `serde` and `serde_derive` seperately Before this commit, serde_derive is built before serde. But serde does not depend on serde_derive, so that is not needed. Instead, build serde and serde_derive in parallel. This speeds up compilation for users depending on rustdoc-json-types out of tree. Imports: rust-lang/rustdoc-types#49 CC ``@Enselic`` r? ``@GuillaumeGomez``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, serde_derive is built before serde. But serde does not depend on serde_derive, so that is not needed. Instead, build serde and serde_derive in parallel. That speeds up compilation by 23%.
Before:
After: