Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rustup installation instructions to README #1421

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Nov 9, 2023

Now that cranelift is distributed with Rustup, I find myself constantly searching for the rust-lang/rust#81746 PR. I think that it would be useful to also describe the Rustup installation/usage instructions here in README.

@lqd
Copy link
Member

lqd commented Nov 9, 2023

https://bjorn3.github.io/2023/10/31/progress-report-oct-2023.html describes the way to use the backend via Cargo.toml in order to not change the compilation commands (and also via cargo's env vars), which could be interesting here as well.

@lqd
Copy link
Member

lqd commented Nov 9, 2023

@lqd
Copy link
Member

lqd commented Nov 10, 2023

And also document this in the unstable book.

@Kobzol
Copy link
Contributor Author

Kobzol commented Nov 11, 2023

Added more usage instructions based on the blog post. Also sent PRs to the perf book (nnethercote/perf-book#72).

I'm not sure if the unstable book is the correct place for this, as it contains just general descriptions of compiler flags. I think that the Rustc book might be more appropriate.

Readme.md Outdated Show resolved Hide resolved
@bjorn3
Copy link
Member

bjorn3 commented Nov 11, 2023

The actual text of the new section looks good to me. It feels a bit weird to have using precompiled versions from rustup first, then manual building and finally using precompiled versions from CI though.

@Kobzol
Copy link
Contributor Author

Kobzol commented Nov 11, 2023

I agree. I think that it makes sense to have the easiest way first though. What order would you prefer?

@bjorn3
Copy link
Member

bjorn3 commented Nov 11, 2023

Maybe swap building it yourself and using the CI artifacts? You would need to reword using the CI artifacts for that as it is currently written as alternative for building yourself.

Now that cranelift is distributed with Rustup, I find myself constantly searching for the rust-lang/rust#81746 PR. I think that it would be useful to also describe the Rustup installation/usage instructions here in README.
@Kobzol
Copy link
Contributor Author

Kobzol commented Nov 11, 2023

I tried to reorganize it a little bit.

@bjorn3 bjorn3 merged commit bf85e18 into rust-lang:master Nov 12, 2023
17 checks passed
@bjorn3
Copy link
Member

bjorn3 commented Nov 12, 2023

Thanks!

@Kobzol Kobzol deleted the patch-1 branch November 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants