Skip to content

Change significance to be determined by IQR fencing #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Sep 8, 2021

This changes how we define (and subsequently implement in code) a "significant" test result to a more formal and less arbitrary mechanism (described below). Additionally, the documentation is updated to reflect this change.

Before
Until we've used a simple threshold of either 0.2% change for non-"dodgy" test cases (i.e., test cases which we've determined to not have some sort of historical noise) and 0.8% for "dodgy" test cases.

After
Significance is defined as being an outlier when compared with historical data. We use interquartile range fencing to determine whether a given result is an outlier.

IQR fencing uses this formula:

interquartile_range = Q3 - Q1
result > Q3 + (interquartile_range * 1.5)

@rylev
Copy link
Member Author

rylev commented Sep 8, 2021

I'd like to hold off on merging this for now since it makes a lot more comparisons show up as "definitely relevant". We should address that first.

@rylev rylev merged commit cd2cd93 into rust-lang:master Sep 9, 2021
@rylev rylev deleted the significance branch September 9, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants