Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy birthday to the last noise run #838

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

Julian-Wollersberger
Copy link
Contributor

The old noise run is from 2020-02-06, which was exactly a year ago.
The new noise run from 2021-02-06 measures the non-functional changes from rust-lang/rust#81792 "Bump nightly version to 1.52.0"

The old noise run is from 2020-02-06, which is exactly a year ago. The new noise run measures #81792 from 2021-02-06.
@bjorn3
Copy link
Member

bjorn3 commented Feb 6, 2021

I don't think a version bump is the most suitable. It likely affects iteration order of multiple hashmaps, thereby introducing noise that doesn't nornally happen.

@Mark-Simulacrum
Copy link
Member

Yes, I agree. It would be better to find something affecting only e.g. README.md or otherwise not even touching .rs files that are part of the libraries or compiler. (Something like a cargo bump would also work).

@Julian-Wollersberger
Copy link
Contributor Author

I don't think a version bump is the most suitable. It likely affects iteration order of multiple hashmaps, thereby introducing noise that doesn't nornally happen.

Oh, I didn't think of that. That's an interesting consideration, thanks for pointing it out.
I'll find another change when I have time, probably next weekend.

@Mark-Simulacrum
Copy link
Member

Thanks. This one looks good to me.

@Mark-Simulacrum Mark-Simulacrum merged commit 21bea4a into rust-lang:master Feb 20, 2021
@Julian-Wollersberger
Copy link
Contributor Author

Wow, you were fast ^^
So for reference, this is from rust-lang/rust#81666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants