Log duration of self-profile parsing #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Jul 6, 2025
|
I wasn't far off, it was ~66s in the last benchmark run. That means that if I made it twice faster, we would save 30 seconds for each benchmark run 🤔 Not sure if it is worth it, tbh, because I had to essentially copy out the code for getting the artifact sizes out of analyzeme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I profiled rustc-perf locally, and it seems like we spent a bunch of time on parsing the self-profile files. This is quite wasteful, because they can be quite large, and we iterate through the whole file, load and allocate all the event labels, and then only take the artifact numbers from it, which is like 6 numbers.
I have code locally that optimizes this so that the loading is 2x faster, but I want to first see how much time we actually spend on this in production. My estimate is around 1 minute per benchmark run.