Skip to content

Remove regex-1.5.5 #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/check-profiling.sh
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ test -f results/eprintln-Test-helloworld-Check-Full
test ! -s results/eprintln-Test-helloworld-Check-Full

# llvm-lines. `Debug` not `Check` because it doesn't support `Check` profiles.
# Including both `helloworld` and `regex-1.5.5` benchmarks, as they exercise the
# Including both `helloworld` and `regex-automata-0.4.8` benchmarks, as they exercise the
# zero dependency and the greater than zero dependency cases, respectively, the
# latter of which has broken before.
RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=debug \
Expand All @@ -146,12 +146,12 @@ RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=
--id Test \
--profiles Debug \
--cargo $bindir/cargo \
--include helloworld,regex-1.5.5 \
--include helloworld,regex-automata-0.4.8 \
--scenarios Full
test -f results/ll-Test-helloworld-Debug-Full
grep -q "Lines.*Copies.*Function name" results/ll-Test-helloworld-Debug-Full
test -f results/ll-Test-regex-1.5.5-Debug-Full
grep -q "Lines.*Copies.*Function name" results/ll-Test-regex-1.5.5-Debug-Full
test -f results/ll-Test-regex-automata-0.4.8-Debug-Full
grep -q "Lines.*Copies.*Function name" results/ll-Test-regex-automata-0.4.8-Debug-Full

# llvm-ir. `Debug` not `Check` because it works better that way.
RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=debug \
Expand Down
6 changes: 3 additions & 3 deletions collector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,14 @@ Finally, while most of the options you can pass to the collector are supported,
the profilers used in the `profile_local` command are not. In Windows, the only currently supported
profiler is the `self-profiler`.

As a complete example, let's run just the `regex-1.5.5` benchmark in the `Debug`
As a complete example, let's run just the `regex-automata-0.4.8` benchmark in the `Debug`
profile with self-profiling results available:

```pwsh
$env:XPERF="C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\xperf.exe"
$env:TRACELOG="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\tracelog.exe"
.\target\release\collector.exe bench_local $env:RUST_ORIGINAL --id Original --profiles Debug --include regex-1.5.5 --self-profile
.\target\release\collector.exe bench_local $env:RUST_MODIFIED --id Modified --profiles Debug --include regex-1.5.5 --self-profile
.\target\release\collector.exe bench_local $env:RUST_ORIGINAL --id Original --profiles Debug --include regex-automata-0.4.8 --self-profile
.\target\release\collector.exe bench_local $env:RUST_MODIFIED --id Modified --profiles Debug --include regex-automata-0.4.8 --self-profile
.\target\release\site.exe .\results.db
```

Expand Down
1 change: 0 additions & 1 deletion collector/compile-benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ They mostly consist of real-world crates.
types, constants, and functions, but relatively little normal code. Stresses the parser. A very widely-used crate.
- **nalgebra-0.33.0**: A linear algebra library. It exercises the new trait solver
in different ways than the old solver.
- **regex-1.5.5**: A regular expression parser. Used by many Rust programs.
- **regex-automata-0.4.8**: A regular expression matching engine. Used by `regex`, which is used by
many Rust programs.
- **ripgrep-13.0.0**: A line-oriented search tool. A widely-used utility, and a
Expand Down
5 changes: 0 additions & 5 deletions collector/compile-benchmarks/REUSE.toml
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,6 @@ path = "regex/**"
SPDX-FileCopyrightText = "The Rust Project Developers (see https://thanks.rust-lang.org)"
SPDX-License-Identifier = "MIT OR Apache-2.0"

[[annotations]]
path = "regex-1.5.5/**"
SPDX-FileCopyrightText = "The Rust Project Developers (see https://thanks.rust-lang.org)"
SPDX-License-Identifier = "MIT OR Apache-2.0"

[[annotations]]
path = "regex-automata-0.4.8/**"
SPDX-FileCopyrightText = "The Rust Project Developers (see https://thanks.rust-lang.org)"
Expand Down
6 changes: 0 additions & 6 deletions collector/compile-benchmarks/regex-1.5.5/.cargo_vcs_info.json

This file was deleted.

7 changes: 0 additions & 7 deletions collector/compile-benchmarks/regex-1.5.5/.gitignore

This file was deleted.

13 changes: 0 additions & 13 deletions collector/compile-benchmarks/regex-1.5.5/0-compile-one.patch

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions collector/compile-benchmarks/regex-1.5.5/2-Compiler-new.patch

This file was deleted.

12 changes: 0 additions & 12 deletions collector/compile-benchmarks/regex-1.5.5/3-reverse.patch

This file was deleted.

13 changes: 0 additions & 13 deletions collector/compile-benchmarks/regex-1.5.5/4-byte-frequencies.patch

This file was deleted.

14 changes: 0 additions & 14 deletions collector/compile-benchmarks/regex-1.5.5/5-Job.patch

This file was deleted.

12 changes: 0 additions & 12 deletions collector/compile-benchmarks/regex-1.5.5/6-println.patch

This file was deleted.

Loading
Loading