Add benchmark detail to compile benchmark in compare page #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove fixed layout hacks and improve the layout w.r.t. the new expansion icon.
Mark-Simulacrum
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an expandable section containing benchmark details to each row in the (compile) comparison table. Later I want to add more data here, e.g. a 30 day history chart, information about recent similar changes to better detect noise, etc.
Currently, the details are opened by clicking on an arrow. Once people get used to it, I would also probably suggest just making the whole row clickable, and move the various links that are present in the individual columns (benchmark column => benchmark source code, profile column => 30 day graph link, change column => detailed query link) to the detail section. These links were quite hidden and unintuitive except to a "select few", who already knew about them :)
table.mp4