Skip to content

Don't ignore rustdoc when generating comparison summaries #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Don't ignore rustdoc when generating comparison summaries #1011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions site/src/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ pub struct ComparisonSummary {
impl ComparisonSummary {
pub fn summarize_comparison(comparison: &Comparison) -> Option<ComparisonSummary> {
let mut comparisons = comparison
.get_individual_comparisons()
.statistics
.iter()
.filter(|c| c.is_significant())
.cloned()
.collect::<Vec<_>>();
Expand Down Expand Up @@ -567,10 +568,6 @@ impl Comparison {
pub fn next(&self, master_commits: &[collector::MasterCommit]) -> Option<String> {
next_commit(&self.b.artifact, master_commits).map(|c| c.sha.clone())
}

fn get_individual_comparisons(&self) -> impl Iterator<Item = &TestResultComparison> {
self.statistics.iter().filter(|b| b.profile != Profile::Doc)
}
}

/// A description of the amount of variance a certain benchmark is historically
Expand Down