Frontend dist files not served correctly

[knagaitsev]

I followed these instructions locally: https://github.com/rust-lang/rustc-perf/tree/master/site

However, I found that after going to the served HTML page, the site/frontend/dist files were all returning 404 errors

Modifying the following line to be #[folder = "frontend/dist/"] (with a trailing slash) fixed the issue for me:

rustc-perf/site/src/resources.rs

Line 23 in 89db057

#[folder = "frontend/dist"]

I'm not sure if the instructions for building/serving the webpage are outdated, but I just wanted to report this solution that worked.

[Kobzol]

Hi, what OS do you have? And what happened when you went to http://localhost:2346? Did you force refresh the page?

It works for me locally, but it's true that the rust-embed documentation does include a trailing slash, and we also use it for the frontend/templates/ directory, so why not, if it helps your use-case. Feel free to send a PR! :)

[knagaitsev]

Actually, the root cause of my issue was not the trailing slash difference, but instead it was the fact that I built the site binary before building the js/css site assets.

I think it would be best to add a note clarifying that the site binary needs to be rebuilt if it was already built.

OS: Ubuntu 22.04
Browser: Chrome

In the dev console, I saw a bunch of errors like:

GET http://localhost:2346/styles/uPlot.min.css net::ERR_ABORTED 404 (Not Found)
...

Reproduce and Fix

This setup will not work, as the site binary was built before the js/css site assets were built:

git clone git@github.com:rust-lang/rustc-perf.git
cd rustc-perf
# build everything first to demonstrate the issue
cargo build --release
cd site/frontend
npm install
npm run build
cd ../..
# this does nothing, because the build system does not recognize that anything changed
# since the last build
cargo build --bin site --release
./target/release/site

This fixes the issue:

cargo clean
cargo build --bin site --release
./target/release/site