Skip to content

Maybe too much noise/undeterminism in our unicode runs atop cachegrind? #1299

Open

Description

Spawned off of rust-lang/rust#95958 (comment) and discussion at https://zulip-archive.rust-lang.org/stream/247081-t-compiler/performance/topic/triage.202022.2004.2019.html#279492421

Following the hints at https://perf.rust-lang.org/detailed-query.html?commit=dc4bfcbdfff651c82eff4bdd311d28e54d1513c4&base_commit=0d13f6afeba4935499abe0c9a07426c94492c94e&benchmark=unicode-normalization-0.1.19-debug&scenario=full, I proceed to try to do local cachegrind runs in order to understand where the regression was coming from.

  • I.e. I was invoking this command: ./target/release/collector profile_local cachegrind +0d13f6afeba4935499abe0c9a07426c94492c94e --rustc2 +dc4bfcbdfff651c82eff4bdd311d28e54d1513c4 --include unicode-normalization-0.1.19 --profiles Debug --scenarios Full

A problem with this was that there was significant variation from run to run, more variation than what we treat as "significant" in our own reporting.

How much noise/variance/undetermism is acceptable, given our current reporting thresholds?

(Can one do multiple cachegrind runs, accumulate their results, and diff the accumulation? Would that help to counter the variance here?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions