Skip to content

add mir-opt section for optimization fuel #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2020
Merged

add mir-opt section for optimization fuel #963

merged 2 commits into from
Nov 22, 2020

Conversation

cjkenn
Copy link
Contributor

@cjkenn cjkenn commented Nov 20, 2020

Fixes #962

@cjkenn
Copy link
Contributor Author

cjkenn commented Nov 20, 2020

I'm not too familiar with how reviews are done for the book, @oli-obk would you like to take a look at this?

@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 20, 2020
oli-obk
oli-obk reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm also not sure about the review process around the guide, but pinging someone who reviewed or worked on the code related to the guide section is always good I think.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 22, 2020

Oh I have merge powers here 😆

@jyn514 jyn514 merged commit da0701b into rust-lang:master Nov 22, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 22, 2020

and I was too slow

@jyn514
Copy link
Member

jyn514 commented Nov 22, 2020

https://www.youtube.com/watch?v=LfmrHTdXgK4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document optimization fuel for MIR optimizations
3 participants
@cjkenn @oli-obk @jyn514