Skip to content

Rebrand ICE-breakers, introduce Windows notification group #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Rebrand ICE-breakers, introduce Windows notification group #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a862c19
rename ice-breakers to the more general notification-group
nikomatsakis May 28, 2020
7afd8d3
add windows notification group
nikomatsakis May 28, 2020
b15497d
rebrand LLVM ICE-breakers as a "notification group"
nikomatsakis May 28, 2020
0d6d87e
include the link to example windows PR
nikomatsakis Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@
- [Emitting Errors and other Diagnostics](diagnostics.md)
- [`LintStore`](./diagnostics/lintstore.md)
- [Diagnostic Codes](./diagnostics/diagnostic-codes.md)
- [ICE-breaker teams](ice-breaker/about.md)
- ["Cleanup Crew" ICE-breakers](ice-breaker/cleanup-crew.md)
- [LLVM ICE-breakers](ice-breaker/llvm.md)
- [Notification groups](notification-groups/about.md)
- ["Cleanup Crew"](notification-groups/cleanup-crew.md)
- [LLVM](notification-groups/llvm.md)
- [Windows](notification-groups/windows.md)
- [Licenses](./licenses.md)
- [Part 2: High-level Compiler Architecture](./part-2-intro.md)
- [Overview of the Compiler](./overview.md)
Expand Down
0 src/ice-breaker/about.md → src/notification-groups/about.md
View file
Open in desktop
File renamed without changes.
0 src/ice-breaker/cleanup-crew.md → src/notification-groups/cleanup-crew.md
View file
Open in desktop
File renamed without changes.
11 changes: 7 additions & 4 deletions src/ice-breaker/llvm.md → src/notification-groups/llvm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# LLVM ICE-breakers
# LLVM Notification group

**Github Label:** [ICEBreaker-LLVM]
**Github Label:** [A-LLVM]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the ICEBreaker-Cleanup-Crew label? Will it stay the same? If not we should edit the reference to it in the cleanup-crew.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should just change it to Cleanup-Crew

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged this with the idea that the labels can be fixed in a follow-up PR.


[ICEBreaker-LLVM]: https://github.com/rust-lang/rust/labels/ICEBreaker-LLVM
[A-LLVM]: https://github.com/rust-lang/rust/labels/A-LLVM

The "LLVM ICE-breakers" are focused on bugs that center around LLVM.
The "LLVM Notification Group" are focused on bugs that center around LLVM.
These bugs often arise because of LLVM optimizations gone awry, or as
the result of an LLVM upgrade. The goal here is:

Expand All @@ -13,6 +13,9 @@ the result of an LLVM upgrade. The goal here is:
- if the former, to fix our IR;
- if the latter, to try and file a bug on LLVM (or identify an existing bug).

The group may also be asked to weigh in on other sorts of LLVM-focused
questions.

## Helpful tips and options

The ["Debugging LLVM"][d] section of the
Expand Down
31 changes: 31 additions & 0 deletions src/notification-groups/windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Windows notification group

**Github Label:** [O-Windows]

[O-Windows]: https://github.com/rust-lang/rust/labels/O-Windows

This list will be used to ask for help both in diagnosing and testing
Windows-related issues as well as suggestions on how to resolve
interesting questions regarding our Windows support.

The group also has an associated Zulip stream (`#t-compiler/windows`)
where people can go to pose questions and discuss Windows-specific
topics.

To get a better idea for what the group will do, here are some
examples of the kinds of questions where we would have reached out to
the group for advice in determining the best course of action:

* Which versions of MinGW should we support?
* Should we remove the legacy InnoSetup GUI installer? [#72569]
* What names should we use for static libraries on Windows? [#29520]

So, if you are interested in participating, please sign up for the
Windows group! To do so, you open a PR against the [rust-lang/team]
repository. Just [follow this example][eg], but change the username to
your own!

[rust-lang/team]: https://github.com/rust-lang/team
[eg]: https://github.com/rust-lang/team/pull/348/
[#72569]: https://github.com/rust-lang/rust/pull/72569
[#29520]: https://github.com/rust-lang/rust/pull/29520