Adjust some doc for Query System#2465
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
|
r? rustc-dev-guide |
| [`wasm_import_module_map`][wasm_import_module_map], that `rustc_driver` can invoke. | ||
| 1. Implement the provider function: | ||
| ```rust,ignore | ||
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: DefId) -> Fubar<'tcx> { ... } |
There was a problem hiding this comment.
will do this change in a future pr
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: DefId) -> Fubar<'tcx> { ... } | |
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: LocalDefId) -> Fubar<'tcx> { ... } |
There was a problem hiding this comment.
oh, I see we now have ExternProvider as well (since rust-lang/rust#85830)... would you be able to adjust docs to account for it @xizheyin
There was a problem hiding this comment.
No problem, I'm just working on this pr rust-lang/rust#142450, which involves extern providers.
There was a problem hiding this comment.
alright... feel free to modify rdg there as well, to avoid having to open a separate pr here
There was a problem hiding this comment.
I thought the changes to rdg could only be made here. It seems that I can submit other improvements in rust-lang/rust in the future.
But for this improvement, I think it would be better to submit it here, because rust-lang/rust may take time to synchronize.
There was a problem hiding this comment.
- larger PRs generally take longer to be reviewed here, so I would not worry about the lag
- doing docs changes on the other side has more chances of being reviewed by someone more familiar with what is being documented on the other side (since they would be the one reviewing the non-doc part)
There was a problem hiding this comment.
I see. In the future, I will submit pr related to a specific code part in rust-lang/rust. Thanks.
3 participants
This PR improves the documentation for the rustc query system.
Providers