Skip to content

[suggested.md] remove deprecated changelog-seen from shell.nix #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[suggested.md] remove deprecated changelog-seen from shell.nix #1805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[suggested.md] remove deprecated changelog-seen from shell.nix 
I noticed the following warning
```
WARNING: The use of `changelog-seen` is deprecated. Please refer to `change-id` option in `config.example.toml` instead.
```

It would be nice to also resolve this warning
```
WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.
note: to silence this warning, add `change-id = 115898` at the top of `config.toml`
```
but I can't think of a sensible way to include the `change-id` in `shell.nix`
  • Loading branch information
@eopb
eopb authored Oct 10, 2023
commit 0882f6250b2e79462a1467aedfb856cc098ecdad
1 change: 0 additions & 1 deletion src/building/suggested.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ let
# `config.toml.example`) from `1bd30ce2aac40c7698aa4a1b9520aa649ff2d1c5`
config = pkgs.writeText "rustc-config" ''
profile = "compiler" # you may want to choose a different profile, like `library` or `tools`
changelog-seen = 2

[build]
patch-binaries-for-nix = true
Expand Down