Skip to content

Conversation

spookyvision
Copy link

be louder about the user needing to put their own target triple in the config

],
"rust-analyzer.rustfmt.overrideCommand": [
"./build/TARGET_TRIPLE/stage0/bin/rustfmt",
"./build/❗YOUR_TARGET_TRIPLE_HERE❗/stage0/bin/rustfmt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use $ for such a case, e.g. https://rustc-dev-guide.rust-lang.org/tests/intro.html#running-tests-on-a-remote-machine

Suggested change
"./build/❗YOUR_TARGET_TRIPLE_HERE❗/stage0/bin/rustfmt",
"./build/$TARGET_TRIPLE/stage0/bin/rustfmt",

@jyn514 jyn514 changed the title 📢 📢 be louder about the user needing to put their own target triple in the config Oct 12, 2021
@camelid camelid added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Oct 12, 2021
@JohnTitor
Copy link
Member

Hey @spookyvision, could you resolve the above comment and merge conflict? Once they're done, we could merge this PR.

@spookyvision
Copy link
Author

Hey @spookyvision, could you resolve the above comment and merge conflict? Once they're done, we could merge this PR.

whoops, didn't see this notification, sorry! I specifically added those emojis because of a conversation in discord, where a person had missed the fact they needed to fill it out. So just adding a $ maybe won't resolve it for them, maybe depending on whether that character changes syntax highlighting in their editor…

@JohnTitor
Copy link
Member

Agree that emojis are more visible, but $FOO usually means a variable and AFAIK it's widely used. Also, #1250 added an additional note, I think it's helpful enough here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: this PR is waiting for additional action by the OP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants