Implement demangling for #[splat] - #90
Merged
Merged
Conversation
wesleywiser
approved these changes
Jul 8, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 13, 2026
…rk-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 13, 2026
…rk-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 13, 2026
…rk-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 13, 2026
…rk-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 13, 2026
Rollup merge of #159202 - teor2345:bump-rustc-demangle, r=Mark-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: #153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in #158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Jul 16, 2026
…crum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang/rust#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang/rust#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 21, 2026
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 22, 2026
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 22, 2026
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 22, 2026
Rollup merge of #158890 - teor2345:splat-mangling-clash, r=wesleywiser Fix splat v0 mangling Tracking issue: #153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: #159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes #158644 This PR was based on #159202, so we waited for that PR to merge first, then rebased this one.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 22, 2026
Fix splat v0 mangling Tracking issue: rust-lang/rust#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang/rust#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang/rust#158644 This PR was based on rust-lang/rust#159202, so we waited for that PR to merge first, then rebased this one.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 23, 2026
…rk-Simulacrum Bump rustc-demangle to 0.1.28 This PR is part of the splat lang experiment: rust-lang#153629 It brings in the changes from rust-lang/rustc-demangle#90, which encode splatted types with a `w` prefix in type mangling. This is required to fix the symbol clashes in rust-lang#158644. We need to upgrade the compiler and standard library to avoid "can't demangle" panics or errors. Some tools might work without the upgrade, but we might as well do it there as well. @rustbot label +C-enhancement +F-splat +T-compiler +A-name-mangling
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements demangling for splat, and adds tests.
The symbols for the tests are from PR rust-lang/rust#158890, UI tests:
This is part of the splat lang experiment: rust-lang/rust#153629
It is needed to fix symbol clashes between function pointer types, see rust-lang/rust#158644