flag '-l link-arg=___ was added #99467

belovdv · 2022-07-19T13:18:53Z

rust-highfive · 2022-07-19T13:18:56Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

oli-obk · 2022-07-19T13:37:56Z

r? @petrochenkov

compiler/rustc_codegen_ssa/src/back/link.rs

src/test/run-make/pass-linker-flags/Makefile

src/test/run-make/pass-linker-flags-upwork/Makefile

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_metadata/src/native_libs.rs

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_session/src/config.rs

petrochenkov · 2022-07-20T18:14:32Z

Could you also squash commits into one after addressing the remaining comments?

petrochenkov · 2022-07-21T11:56:13Z

@bors r+

bors · 2022-07-21T11:56:15Z

📌 Commit f4816de has been approved by petrochenkov

It is now in the queue for this repository.

…ochenkov flag '-l link-arg=___ was added rust-lang#99427

GuillaumeGomez · 2022-07-23T21:33:46Z

I think this is the one which failed in #99649.

@bors r-

arbitrary link argument like -C link-arg, but respecting relative order to other `-l` options, unstable

petrochenkov · 2022-07-26T11:06:58Z

@bors r+

bors · 2022-07-26T11:07:00Z

📌 Commit 7d4a98e has been approved by petrochenkov

It is now in the queue for this repository.

…ochenkov flag '-l link-arg=___ was added rust-lang#99427

Dylan-DPC · 2022-07-29T13:08:46Z

@bors p=1 (been in the queue for a few days now)

bors · 2022-07-29T15:36:55Z

⌛ Testing commit 7d4a98e with merge 5dda74a...

bors · 2022-07-29T18:20:24Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 5dda74a to master...

rust-timer · 2022-07-29T22:26:51Z

Finished benchmarking commit (5dda74a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	3.3%	3.3%	1
Regressions 😿 (secondary)	2.7%	2.9%	2
Improvements 🎉 (primary)	-1.7%	-2.4%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.0%	3.3%	3

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.4%	4.4%	1
Improvements 🎉 (primary)	-2.1%	-2.1%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.1%	-2.1%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 19, 2022

rust-highfive assigned oli-obk Jul 19, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2022

rust-highfive assigned petrochenkov and unassigned oli-obk Jul 19, 2022

petrochenkov reviewed Jul 19, 2022

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022

belovdv force-pushed the add_option_link_arg branch from 6e44cc1 to 44defb5 Compare July 20, 2022 12:42

petrochenkov reviewed Jul 20, 2022

View reviewed changes

compiler/rustc_metadata/src/native_libs.rs Outdated Show resolved Hide resolved

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

belovdv force-pushed the add_option_link_arg branch from 44defb5 to 83e9b5a Compare July 20, 2022 15:17

petrochenkov reviewed Jul 20, 2022

View reviewed changes

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

petrochenkov mentioned this pull request Jul 20, 2022

Tracking Issue for linker arguments respecting their relative order with -l library options #99427

Open

3 tasks

belovdv force-pushed the add_option_link_arg branch from 426a337 to f4816de Compare July 21, 2022 11:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2022

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 23, 2022

Rollup merge of rust-lang#99467 - BelovDV:add_option_link_arg, r=petr…

0e87df4

…ochenkov flag '-l link-arg=___ was added rust-lang#99427

GuillaumeGomez mentioned this pull request Jul 23, 2022

Rollup of 5 pull requests #99649

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2022

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 25, 2022

Lib kind -l link-arg:

7d4a98e

arbitrary link argument like -C link-arg, but respecting relative order to other `-l` options, unstable

belovdv force-pushed the add_option_link_arg branch from 12d09c9 to 7d4a98e Compare July 26, 2022 11:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2022

petrochenkov mentioned this pull request Jul 27, 2022

[WIP] add -Z split_bundled_libs #99773

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2022

Rollup merge of rust-lang#99467 - BelovDV:add_option_link_arg, r=petr…

be06049

…ochenkov flag '-l link-arg=___ was added rust-lang#99427

GuillaumeGomez mentioned this pull request Jul 27, 2022

Rollup of 6 pull requests #99826

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2022

bors merged commit 5dda74a into rust-lang:master Jul 29, 2022

rustbot added this to the 1.64.0 milestone Jul 29, 2022

flag '-l link-arg=___ was added #99467

flag '-l link-arg=___ was added #99467

Uh oh!

Conversation

belovdv commented Jul 19, 2022

Uh oh!

rust-highfive commented Jul 19, 2022

Uh oh!

oli-obk commented Jul 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jul 20, 2022

Uh oh!

petrochenkov commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

GuillaumeGomez commented Jul 23, 2022

Uh oh!

petrochenkov commented Jul 26, 2022

Uh oh!

bors commented Jul 26, 2022

Uh oh!

Dylan-DPC commented Jul 29, 2022

Uh oh!

bors commented Jul 29, 2022

Uh oh!

bors commented Jul 29, 2022

Uh oh!

rust-timer commented Jul 29, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants