Allow ValTree::try_to_raw_bytes on u8 array
#99358
Conversation
rustbot
added
the
T-compiler
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| // build-pass | ||
| //[mir] compile-flags: -Zunpretty=mir |
There was a problem hiding this comment.
IMO a separate test should be added. It is not super clear from looking at #70408 why this unpretty is necessary or why it is relevant to what’s described in the issue.
There was a problem hiding this comment.
I can split it out, I just didn't want to duplicate the file.
compiler-errors
force-pushed
the
issue-99325
branch
from
b2567ce
to
db98ffd
Compare
| .collect::<Vec<_>>(); | ||
|
|
||
| return Some(tcx.arena.alloc_from_iter(leafs.into_iter())); |
There was a problem hiding this comment.
is it possible to not collect as an intermediate step but just pass the iterator directly to the arena?
| @@ -0,0 +1,14 @@ | |||
| // build-pass | |||
| // compile-flags: -Zunpretty=mir | |||
There was a problem hiding this comment.
if you can reproduce with -Zdump-mir=main or -Zdump-mir=function_with_bytes, then you could turn this into a mir opt test instead of a ui test with mir output.
compiler-errors
added
S-waiting-on-author
|
r? @oli-obk |
compiler-errors
force-pushed
the
issue-99325
branch
from
db98ffd
to
91e91d8
Compare
|
@rustbot ready Converted to mir-opt test and addressed comments. |
rustbot
added
S-waiting-on-review
| }, | ||
| _ => {} | ||
| // `[u8; N]` can be interpreted as raw bytes | ||
| ty::Array(array_ty, _) if *array_ty == tcx.types.u8 => {} |
There was a problem hiding this comment.
That's odd... why is this one not behind a reference?
There was a problem hiding this comment.
Is the caller peeling references? But only for Sized pointers?
There was a problem hiding this comment.
No, the old implementation just used to never hit this path because for [u8, _] we got the raw bytes of the allocation: 705d818#diff-b56d8c5fa3d7803c5b0e19e1a8854d85c302974484c4c20bf51c76a19556f4a7L1459 -- it was rewritten to use valtree.try_to_raw_bytes but I guess never tested to hit this ICE.
|
@bors r+ |
bors
added
S-waiting-on-bors
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#94247 (Fix slice::ChunksMut aliasing) - rust-lang#99358 (Allow `ValTree::try_to_raw_bytes` on `u8` array) - rust-lang#99651 (Deeply deny fn and raw ptrs in const generics) - rust-lang#99710 (lint: add bad opt access internal lint) - rust-lang#99717 (Add some comments to the docs issue template to clarify) - rust-lang#99728 (Clean up HIR-based lifetime resolution) - rust-lang#99812 (Fix headings colors) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #99325
cc @b-naber I think who touched this last in 705d818