Skip to content

Fix source sidebar bugs #98671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2022
Merged

Fix source sidebar bugs #98671

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27ff258
Fix height for the source sidebar in mobile mode
GuillaumeGomez Jun 29, 2022
ea97bdc
Update/add tests for source sidebar in mobile mode
GuillaumeGomez Jun 29, 2022
ad970a7
Fix display of toggle on expanded source sidebar
GuillaumeGomez Jun 29, 2022
be56963
Add test for source sidebar toggle
GuillaumeGomez Jun 29, 2022
277b77a
Update browser-ui-test version to 0.9.7
GuillaumeGomez Jun 29, 2022
72f6322
Fix scroll when source sidebar is open on mobile
GuillaumeGomez Jun 29, 2022
9a1f52d
Add test to ensure that scroll position is kept when opening/closing …
GuillaumeGomez Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for source sidebar toggle
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Jun 29, 2022
commit be569634e17e4fe172029e499006d2bd4dbde901
14 changes: 13 additions & 1 deletion src/test/rustdoc-gui/sidebar-source-code-display.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,16 @@ wait-for-css: ("#sidebar-toggle", {"visibility": "visible", "opacity": 1})

// We now check it takes the full size of the display.
assert-property: ("body", {"clientWidth": "500", "clientHeight": "700"})
assert-property: (".sidebar", {"clientWidth": "500", "clientHeight": "700"})
assert-property: (".sidebar", {"clientWidth": "500", "clientHeight": "700"})

// We now check the display of the toggle once the sidebar is expanded.
assert-property: ("#sidebar-toggle", {"clientWidth": "500", "clientHeight": "39"})
assert-css: (
"#sidebar-toggle",
{
"border-top-width": "0px",
"border-right-width": "0px",
"border-left-width": "0px",
"border-bottom-width": "1px",
},
)