Skip to content

lints: mostly translatable diagnostics #98624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Jul 5, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
7d2eba6
middle: translation in `LintDiagnosticBuilder`
davidtwco Jun 27, 2022
0f4c4c5
lint: port array-into-iter diagnostics
davidtwco Jun 27, 2022
2a69640
lint: port enum intrinsics diagnostics
davidtwco Jun 27, 2022
a0624eb
lint: port expectation diagnostics
davidtwco Jun 27, 2022
fd57269
lint: port hidden unicode codepoints diagnostics
davidtwco Jun 27, 2022
e88916c
lint: port default hash types diagnostics
davidtwco Jun 27, 2022
8139542
lint: port query instability diagnostics
davidtwco Jun 27, 2022
0996a7a
lint: port ty diagnostics
davidtwco Jun 27, 2022
1c3a3e0
lint: port impl `LintPass` by hand diagnostics
davidtwco Jun 27, 2022
674ac60
lint: port non-existant doc keyword diagnostics
davidtwco Jun 27, 2022
4f35c79
lint: port translation migration diagnostics
davidtwco Jun 27, 2022
c29e05e
lint: port `CString` ptr diagnostics
davidtwco Jun 27, 2022
48e4bf1
lint: port non-ascii-idents diagnostics
davidtwco Jun 27, 2022
7ee4aa7
lint: port non-fmt-panic diagnostics
davidtwco Jun 27, 2022
096a69d
lint: port non-standard style diagnostics
davidtwco Jun 27, 2022
855f237
lint: port no-op method call diagnostics
davidtwco Jun 27, 2022
37588d6
lint: port pass-by-value diagnostics
davidtwco Jun 27, 2022
8e83656
lint: port redundant semicolons diagnostics
davidtwco Jun 27, 2022
7ef610c
lint: port drop trait/glue diagnostics
davidtwco Jun 27, 2022
7a9bef4
lint: port overflowing literals diagnostics
davidtwco Jun 27, 2022
e5f2e0e
lint: port improper ctypes diagnostics
davidtwco Jun 28, 2022
14c3016
lint: port variant size difference diagnostics
davidtwco Jun 28, 2022
0602729
lint: port atomic ordering diagnostics
davidtwco Jun 28, 2022
1999a4c
lint: port unused diagnostics
davidtwco Jun 28, 2022
2829f51
lint: port path statement diagnostics
davidtwco Jun 28, 2022
fc4f8d9
lint: port unused delimiter diagnostics
davidtwco Jun 28, 2022
e248338
lint: port unused import braces diagnostics
davidtwco Jun 28, 2022
4f7b10f
lint: port unused allocation diagnostics
davidtwco Jun 28, 2022
588977b
lint: port while true diagnostics
davidtwco Jun 28, 2022
d433c9a
lint: port box pointers diagnostics
davidtwco Jun 28, 2022
4c63a21
lint: port non-shorthand pattern diagnostics
davidtwco Jun 28, 2022
7dffd14
lint: port unsafe diagnostics
davidtwco Jun 28, 2022
82bd2c2
lint: port missing documentation diagnostics
davidtwco Jun 28, 2022
28655bc
lint: port missing copy impl diagnostics
davidtwco Jun 28, 2022
284ec37
lint: port missing debug impl diagnostics
davidtwco Jun 28, 2022
18a48c1
lint: port anonymous parameter diagnostics
davidtwco Jun 28, 2022
e151d66
lint: port deprecated attr diagnostics
davidtwco Jun 28, 2022
a13b70e
lint: port unused doc comment diagnostics
davidtwco Jun 28, 2022
dbdbdb6
lint: port no-mangle diagnostics
davidtwco Jun 28, 2022
d071f50
lint: port mutable transmutes diagnostic
davidtwco Jun 28, 2022
23ee3e0
lint: port unstable feature diagnostics
davidtwco Jun 28, 2022
dbced10
lint: port unreachable `pub` diagnostic
davidtwco Jun 28, 2022
01a64af
lint: port type alias bounds diagnostics
davidtwco Jun 28, 2022
3c9bda5
lint: port trivial bounds diagnostics
davidtwco Jun 28, 2022
3a498a7
lint: port `...` range pattern diagnostics
davidtwco Jun 28, 2022
10f2d3f
lint: port test items diagnostics
davidtwco Jun 28, 2022
1067641
lint: port keyword idents diagnostics
davidtwco Jun 28, 2022
acea23e
lint: port explicit outlives diagnostics
davidtwco Jun 28, 2022
bd8fe82
lint: port incomplete features diagnostics
davidtwco Jun 28, 2022
157cbbc
lint: add todo for invalid value diagnostics
davidtwco Jun 28, 2022
2e563a4
lint: port clashing extern diagnostics
davidtwco Jun 28, 2022
5524ca1
lint: port deref nullptr diagnostics
davidtwco Jun 28, 2022
fedd4c6
lint: port asm labels diagnostics
davidtwco Jun 28, 2022
9ff6c77
tests: avoid inadvertent diffs in diag derive test
davidtwco Jun 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: port anonymous parameter diagnostics
Signed-off-by: David Wood <david.wood@huawei.com>
  • Loading branch information
davidtwco committed Jun 30, 2022
commit 18a48c1d6c7815eb56bac3798819a3d109e5c95c
3 changes: 3 additions & 0 deletions compiler/rustc_error_messages/locales/en-US/lint.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,6 @@ lint-builtin-missing-copy-impl = type could implement `Copy`; consider adding `i

lint-builtin-missing-debug-impl =
type does not implement `{$debug}`; consider adding `#[derive(Debug)]` or a manual implementation

lint-builtin-anonymous-params = anonymous parameters are deprecated and will be removed in the next edition
.suggestion = try naming the parameter or explicitly ignoring it
20 changes: 8 additions & 12 deletions compiler/rustc_lint/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -937,18 +937,14 @@ impl EarlyLintPass for AnonymousParameters {
("<type>", Applicability::HasPlaceholders)
};

lint.build(
"anonymous parameters are deprecated and will be \
removed in the next edition",
)
.span_suggestion(
arg.pat.span,
"try naming the parameter or explicitly \
ignoring it",
format!("_: {}", ty_snip),
appl,
)
.emit();
lint.build(fluent::lint::builtin_anonymous_params)
.span_suggestion(
arg.pat.span,
fluent::lint::suggestion,
format!("_: {}", ty_snip),
appl,
)
.emit();
})
}
}
Expand Down