Rollup of 8 pull requests #98060
Closed
Rollup of 8 pull requests #98060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issues97981
…am-ty, r=oli-obk Normalize consts' tys when relating with `adt_const_params` Fixes rust-lang#97007
…requirements, r=pnkfelix Remove the `infer_static_outlives_requirements` feature Closes rust-lang#54185 r? `@pnkfelix`
interpret: unify offset_from check with offset check `offset` does the check with a single `check_ptr_access` call while `offset_from` used two calls. Make them both just one one call. I originally intended to actually factor this into a common function, but I am no longer sure if that makes a lot of sense... the two functions start with pretty different precondition (e.g. `offset` *knows* that the 2nd pointer has the same provenance). I also reworded the UB messages a little. Saying it "cannot" do something is not how we usually phrase UB (as far as I know). Instead it's not *allowed* to do that. r? `````@oli-obk`````
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? `````@nikomatsakis````` cc `````@rust-lang/types`````
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: ````@davidtwco````
[issues:97981] del unrelated comment fixes rust-lang#97981 summary: del unrelated comment
Document an edge case of `str::split_once`
Update miri r? `@ghost` fixes rust-lang#98036
rustbot
added
T-compiler
|
@bors r+ rollup=never p=8 |
|
📌 Commit b5e42a4 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b5e42a4 with merge 801bf0be13853a32202bf8a9d0d776e84f06efbc... |
|
Something wrong with GH runners? Jobs cancelled few times in rollups without exact errors ( |
|
mh wtf |
|
maybe more luck with #98066 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
adt_const_params#97709 (Normalize consts' tys when relating withadt_const_params)infer_static_outlives_requirementsfeature #97875 (Remove theinfer_static_outlives_requirementsfeature)type_changing_struct_updateno longer an incomplete feature #97999 (Maketype_changing_struct_updateno longer an incomplete feature)to_stringandString::new#98043 (Remove unnecessaryto_stringandString::new)str::split_once#98049 (Document an edge case ofstr::split_once)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup