Skip to content

Forbid nested opaque types to reference HRTB from opaque types. #97040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2022
Merged

Forbid nested opaque types to reference HRTB from opaque types. #97040

merged 2 commits into from
May 14, 2022

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented May 14, 2022

Backport version of #97039 if useful.

r? @Mark-Simulacrum

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 14, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented May 14, 2022

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2022
@cjgillot cjgillot mentioned this pull request May 14, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

jackh726 commented May 14, 2022

r=me after test is blessed. @cjgillot if you don't get to this by this afternoon, I'll probably pull this and bless.

@bors p=1

@cjgillot cjgillot force-pushed the no-rpit-hrtb-beta branch from 6591121 to 7d0f04a Compare May 14, 2022 15:04
@jackh726
Copy link
Member

jackh726 commented May 14, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented May 14, 2022

📌 Commit 7d0f04a has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2022
@bors
Copy link
Collaborator

bors commented May 14, 2022

⌛ Testing commit 7d0f04a with merge 30a5146...

@bors
Copy link
Collaborator

bors commented May 14, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 30a5146 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2022
@bors bors merged commit 30a5146 into rust-lang:beta May 14, 2022
@rustbot rustbot added this to the 1.61.0 milestone May 14, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 15, 2022
Merged
@cjgillot cjgillot deleted the no-rpit-hrtb-beta branch May 17, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot @rust-highfive @rust-log-analyzer @jackh726 @bors @Mark-Simulacrum @rustbot