Skip to content

[CI] Build ninja on Linux Docker CI builds #96969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 12, 2022

I want to test if/how much using ninja instead of make speeds up try/dist Linux CI builds. They rebuild LLVM several times, so it could be worth it.

@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

r? @Mark-Simulacrum

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 95efb00 with merge 0e42a59c953047a7e00c8e17cfc869f49ebf7a68...

@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

@bors try-

@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 31cb150 with merge 94cb68b0f11cd9dbcdbd2e129b5304d6ce471ae4...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Try build successful - checks-actions
Build commit: 94cb68b0f11cd9dbcdbd2e129b5304d6ce471ae4 (94cb68b0f11cd9dbcdbd2e129b5304d6ce471ae4)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

Ninja is now built in Docker. Now let's see what happens if we actually enable it. For reference, lately dist times have been in the range 1h 20 min - 1h 40 min.

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 139f3bc with merge 413fdf1cf42db425f2245b8b2b6ca43031ce75d6...

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Try build successful - checks-actions
Build commit: 413fdf1cf42db425f2245b8b2b6ca43031ce75d6 (413fdf1cf42db425f2245b8b2b6ca43031ce75d6)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

It seems that building with ninja is actually slower on CI (it took ~2 hours to build).

@Kobzol Kobzol closed this May 12, 2022
@Kobzol Kobzol reopened this May 12, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

@bors try

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Trying commit 139f3bc with merge 572ba4359edc03a746e930674acaf1b3752844d8...

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Try build successful - checks-actions
Build commit: 572ba4359edc03a746e930674acaf1b3752844d8 (572ba4359edc03a746e930674acaf1b3752844d8)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 12, 2022

I was a bit pessimistic towards ninja before, as I didn't realize that the sccache wasn't primed, so the build was slower. But anyways the build is not faster with ninja, it's on par with make. So this is not worth it.

@Kobzol Kobzol closed this May 12, 2022
@Kobzol Kobzol deleted the ci-ninja branch May 12, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants