Skip to content

rustdoc: search result ranking fix #96879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2022
Merged

rustdoc: search result ranking fix #96879

merged 2 commits into from
May 10, 2022

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented May 9, 2022 •
edited
Loading

Before

image

After

image

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 9, 2022
@rust-highfive
Copy link
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2022
@GuillaumeGomez
Copy link
Member

This is a great improvement! Could you add the test you used for HashSet::insert too please? (in rustdoc-js-std)

GuillaumeGomez
GuillaumeGomez reviewed May 9, 2022
View reviewed changes
@notriddle
Copy link
Contributor Author

Okay, I've added a test case for hashset::insert in std.

@notriddle notriddle force-pushed the notriddle/search-ranking branch from 471b0bc to c683810 Compare May 9, 2022 19:19
@notriddle notriddle force-pushed the notriddle/search-ranking branch from c683810 to a9a90d4 Compare May 9, 2022 19:24
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented May 9, 2022

📌 Commit a9a90d4 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
@oli-obk
Copy link
Contributor

oli-obk commented May 10, 2022

@bors rollup

@JohnTitor JohnTitor mentioned this pull request May 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2022
@bors
Auto merge of rust-lang#96904 - JohnTitor:rollup-f1sz5x0, r=JohnTitor
d4c3643 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96717 (Handle mismatched generic param kinds in trait impls betterly)
 - rust-lang#96725 (Expose process windows_process_extensions_main_thread_handle on Windows)
 - rust-lang#96849 (Move some tests to more reasonable places)
 - rust-lang#96861 (Use Rust 2021 prelude in std itself.)
 - rust-lang#96879 (rustdoc: search result ranking fix)
 - rust-lang#96882 (Don't subst an AdtDef with its own substs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d34915f into rust-lang:master May 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 10, 2022
@notriddle notriddle deleted the notriddle/search-ranking branch May 11, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jsha jsha

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

7 participants

@notriddle @rust-highfive @GuillaumeGomez @bors @oli-obk @jsha @rustbot