Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #95941

Closed
wants to merge 32 commits into from
Closed

Rollup of 7 pull requests #95941

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f1a4041
Return status from futex_wake().
m-ou-se Apr 6, 2022
4f28344
Improve documentation of `Place` and `Operand`
JakobDegen Mar 24, 2022
8368590
Adjust computation of place types to detect more invalid places
JakobDegen Mar 24, 2022
e000179
Add documentation for the semantics of MIR rvalues
JakobDegen Mar 25, 2022
5fc8676
Extend the MIR validator to check many more things around rvalues.
JakobDegen Mar 25, 2022
148beaf
Improve documentation for MIR statement kinds.
JakobDegen Mar 25, 2022
c996bc0
Improve documentation for MIR terminators
JakobDegen Mar 26, 2022
3c169f3
Adjust MIR validator to check a few more things for terminators
JakobDegen Mar 26, 2022
8ef4af7
Improve MIR phases documentation with summaries of changes
JakobDegen Mar 26, 2022
14fb427
Address various comments and change some details around place to valu…
JakobDegen Mar 27, 2022
6cb463c
Add futex-based RwLock on Linux.
m-ou-se Apr 6, 2022
307aa58
Fix typo in futex rwlock.
m-ou-se Apr 8, 2022
a5d2c04
Add more clarifications in response to Ralf's comments
JakobDegen Apr 8, 2022
9745a17
Remove rule that place loads may not happen with variant index set
JakobDegen Apr 9, 2022
bf3ef0d
Switch to the 'normal' basic block for writing asm outputs if needed.
luqmana Apr 9, 2022
0b2f360
Update asm-may_unwind test to handle use of asm with outputs.
luqmana Apr 9, 2022
bb3a071
Fix formatting error in pin.rs docs
nyanpasu64 Apr 10, 2022
b92cd1a
Clarify str::from_utf8_unchecked's invariants
CAD97 Apr 10, 2022
986c168
Remove duplicate aliases for `codegen_{cranelift,gcc}`
jyn514 Apr 10, 2022
4c14383
Add `build compiler/rustc_codegen_gcc` as an alias for `CodegenBackend`
jyn514 Apr 10, 2022
aeb3df7
CI: do not compile libcore twice when performing LLVM PGO
Kobzol Apr 11, 2022
7c28791
Add doc comments to futex operations.
m-ou-se Apr 11, 2022
1f2c2bb
Add comments to futex rwlock implementation.
m-ou-se Apr 11, 2022
c4a4f48
Use compare_exchange_weak in futex rwlock implementation.
m-ou-se Apr 11, 2022
8339381
Use is_ or has_ prefix for pure `-> bool` functions.
m-ou-se Apr 11, 2022
88a138e
Rollup merge of #95320 - JakobDegen:mir-docs, r=oli-obk
Dylan-DPC Apr 11, 2022
482655d
Rollup merge of #95801 - m-ou-se:futex-rwlock, r=Amanieu
Dylan-DPC Apr 11, 2022
21ed87b
Rollup merge of #95864 - luqmana:inline-asm-unwind-store-miscompile, …
Dylan-DPC Apr 11, 2022
fac70d8
Rollup merge of #95894 - nyanpasu64:fix-pin-docs, r=Dylan-DPC
Dylan-DPC Apr 11, 2022
5bf0d4e
Rollup merge of #95895 - CAD97:patch-2, r=Dylan-DPC
Dylan-DPC Apr 11, 2022
c641fed
Rollup merge of #95901 - jyn514:remove-duplicate-aliases, r=Mark-Simu…
Dylan-DPC Apr 11, 2022
633e004
Rollup merge of #95927 - Kobzol:ci-pgo-libcore, r=lqd
Dylan-DPC Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in futex rwlock. 
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
  • Loading branch information
@m-ou-se @Amanieu
m-ou-se and Amanieu authored Apr 8, 2022
commit 307aa588f42b65cbce27f0e366197e27ef531c77
2 changes: 1 addition & 1 deletion library/std/src/sys/unix/locks/futex_rwlock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl RwLock {

#[inline]
pub unsafe fn read_unlock(&self) {
let state = self.state.fetch_sub(READ_LOCKED, Release) - 1;
let state = self.state.fetch_sub(READ_LOCKED, Release) - READ_LOCKED;

// It's impossible for a reader to be waiting on a read-locked RwLock,
// except if there is also a writer waiting.
Expand Down