Skip to content

Overlap inherent impls #95082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 25, 2022
Merged

Overlap inherent impls #95082

merged 9 commits into from
Mar 25, 2022

Conversation

spastorino
Copy link
Member

@spastorino spastorino commented Mar 18, 2022 •
edited
Loading

r? @nikomatsakis

Closes #94526

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
spastorino
spastorino commented Mar 18, 2022
View reviewed changes
nikomatsakis
nikomatsakis reviewed Mar 18, 2022
View reviewed changes
@cjgillot cjgillot mentioned this pull request Mar 18, 2022
Open
4 tasks
nikomatsakis
nikomatsakis requested changes Mar 21, 2022
View reviewed changes
@spastorino spastorino force-pushed the overlap-inherent-impls branch 3 times, most recently from 3ed2718 to 02fdab7 Compare March 24, 2022 15:41
@spastorino spastorino force-pushed the overlap-inherent-impls branch from 02fdab7 to 22b311b Compare March 24, 2022 15:44
nikomatsakis
nikomatsakis requested changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer. Can be simpler still!

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 25, 2022

📌 Commit 42e986f has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2022
@bors
Copy link
Collaborator

bors commented Mar 25, 2022

⌛ Testing commit 42e986f with merge e70e211...

@bors
Copy link
Collaborator

bors commented Mar 25, 2022

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing e70e211 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2022
@bors bors merged commit e70e211 into rust-lang:master Mar 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e70e211): comparison url.

Summary: This benchmark run shows 23 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -1.0%
  • Largest improvement in instruction counts: -2.0% on full builds of diesel-1.4.8 check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Nightly regression for #![feature(with_negative_coherence)]
6 participants
@spastorino @nikomatsakis @bors @rust-timer @rust-highfive @rustbot