improve comments for simplify_type
#94057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #94072) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr
force-pushed
the
simplify_type-uwu
branch
from
1e1ca93 to
4675fcc
Compare
lcnr
changed the title
simplify_typesimplify_type
lcnr
force-pushed
the
simplify_type-uwu
branch
2 times, most recently
from
c95a2ae to
0efb883
Compare
lcnr
force-pushed
the
simplify_type-uwu
branch
from
0efb883 to
55f938b
Compare
lqd
reviewed
Feb 21, 2022
nikomatsakis
approved these changes
Mar 3, 2022
|
@bors r+ |
|
📌 Commit ba2e0ca has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 3, 2022
improve comments for `simplify_type` Should now correctly describe what's going on. Experimented with checking the invariant for projections but that ended up requiring fairly involved changes. I assume that it is not possible to get unsoundness here, at least for now and I can pretty much guarantee that it's impossible to trigger it by accident. r? ````@nikomatsakis```` cc rust-lang#92721
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92697 (Use cgroup quotas for calculating `available_parallelism`) - rust-lang#94057 (improve comments for `simplify_type`) - rust-lang#94547 (`parse_tt` cleanups) - rust-lang#94550 (rustdoc: Add test for higher kinded functions generated by macros) - rust-lang#94551 (Doc: Fix use of quote instead of backstick in Adapter::map.) - rust-lang#94554 (Fix invalid lint_node_id being put on a removed stmt) - rust-lang#94555 (all: fix some typos) - rust-lang#94563 (Remove a unnecessary `..` pattern) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
`simplify_type` improvements and cursed docs the existing `TreatParams` enum pretty much mixes everything up. Not sure why this looked right to me in rust-lang#94057 This also includes two changes which impact perf: - `ty::Projection` with inference vars shouldn't be treated as a rigid type, even if fully normalized - `ty::Placeholder` only unifies with itself, so actually return `Some` for them r? `@nikomatsakis`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should now correctly describe what's going on. Experimented with checking the invariant for projections
but that ended up requiring fairly involved changes. I assume that it is not possible to get unsoundness here,
at least for now and I can pretty much guarantee that it's impossible to trigger it by accident.
r? @nikomatsakis cc #92721