-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggestion to slice if scurtinee is a reference to Result
or Option
#93981
Merged
bors
merged 1 commit into
rust-lang:master
from
ChayimFriedman2:slice-pat-reference-option-result
Feb 17, 2022
Merged
Fix suggestion to slice if scurtinee is a reference to Result
or Option
#93981
bors
merged 1 commit into
rust-lang:master
from
ChayimFriedman2:slice-pat-reference-option-result
Feb 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Feb 14, 2022
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 14, 2022
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
slice-pat-reference-option-result
branch
from
February 14, 2022 00:08
dfbfd28
to
150c7af
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
slice-pat-reference-option-result
branch
3 times, most recently
from
February 14, 2022 00:17
6fff3ac
to
39a1383
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
slice-pat-reference-option-result
branch
from
February 14, 2022 00:34
39a1383
to
2307322
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
slice-pat-reference-option-result
branch
from
February 14, 2022 00:55
2307322
to
d9592d9
Compare
davidtwco
approved these changes
Feb 16, 2022
Thanks! @bors r+ |
📌 Commit d9592d9 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2022
…-option-result, r=davidtwco Fix suggestion to slice if scurtinee is a reference to `Result` or `Option` Fixes rust-lang#91343 (comment) and rust-lang#91343 (comment).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 16, 2022
…-option-result, r=davidtwco Fix suggestion to slice if scurtinee is a reference to `Result` or `Option` Fixes rust-lang#91343 (comment) and rust-lang#91343 (comment).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89869 (Add documentation to more `From::from` implementations.) - rust-lang#93479 (Use `optflag` for `--report-time`) - rust-lang#93693 (Suggest deriving required supertraits) - rust-lang#93981 (Fix suggestion to slice if scurtinee is a reference to `Result` or `Option`) - rust-lang#93996 (Do not suggest "is a function" for free variables) - rust-lang#94030 (Correctly mark the span of captured arguments in `format_args!()`) - rust-lang#94031 ([diagnostics] Add mentions to `Copy` types being valid for `union` fields) - rust-lang#94064 (Update dist-x86_64-musl to Ubuntu 20.04) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91343 (comment) and #91343 (comment).