Skip to content

Add [f32]::sort_floats and [f64]::sort_floats #93397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add [f32]::sort_floats and [f64]::sort_floats
It's inconvenient to sort a slice or Vec of floats, compared to sorting
integers. To simplify numeric code, add a convenience method to `[f32]`
and `[f64]` to sort them using `sort_unstable_by` with `total_cmp`.
  • Loading branch information
joshtriplett committed Jun 20, 2022
commit bded8fcfc0a0735071f41bec5d9a388e8c0c7c7c
60 changes: 60 additions & 0 deletions library/core/src/slice/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4100,6 +4100,66 @@ impl<T, const N: usize> [[T; N]] {
}
}

#[cfg(not(bootstrap))]
#[cfg(not(test))]
impl [f32] {
/// Sorts the slice of floats.
///
/// This sort is in-place (i.e. does not allocate), *O*(*n* \* log(*n*)) worst-case, and uses
/// the ordering defined by [`f32::total_cmp`].
///
/// # Current implementation
///
/// This uses the same sorting algorithm as [`sort_unstable_by`](slice::sort_unstable_by).
///
/// # Examples
///
/// ```
/// #![feature(sort_floats)]
/// let mut v = [2.6, -5e-8, f32::NAN, 8.29, f32::INFINITY, -1.0, 0.0, -f32::INFINITY, -0.0];
///
/// v.sort_floats();
/// let sorted = [-f32::INFINITY, -1.0, -5e-8, -0.0, 0.0, 2.6, 8.29, f32::INFINITY, f32::NAN];
/// assert_eq!(&v[..8], &sorted[..8]);
/// assert!(v[8].is_nan());
/// ```
#[unstable(feature = "sort_floats", issue = "93396")]
#[inline]
pub fn sort_floats(&mut self) {
self.sort_unstable_by(f32::total_cmp);
}
}

#[cfg(not(bootstrap))]
#[cfg(not(test))]
impl [f64] {
/// Sorts the slice of floats.
///
/// This sort is in-place (i.e. does not allocate), *O*(*n* \* log(*n*)) worst-case, and uses
/// the ordering defined by [`f64::total_cmp`].
///
/// # Current implementation
///
/// This uses the same sorting algorithm as [`sort_unstable_by`](slice::sort_unstable_by).
///
/// # Examples
///
/// ```
/// #![feature(sort_floats)]
/// let mut v = [2.6, -5e-8, f64::NAN, 8.29, f64::INFINITY, -1.0, 0.0, -f64::INFINITY, -0.0];
///
/// v.sort_floats();
/// let sorted = [-f64::INFINITY, -1.0, -5e-8, -0.0, 0.0, 2.6, 8.29, f64::INFINITY, f64::NAN];
/// assert_eq!(&v[..8], &sorted[..8]);
/// assert!(v[8].is_nan());
/// ```
#[unstable(feature = "sort_floats", issue = "93396")]
#[inline]
pub fn sort_floats(&mut self) {
self.sort_unstable_by(f64::total_cmp);
}
}

trait CloneFromSpec<T> {
fn spec_clone_from(&mut self, src: &[T]);
}
Expand Down