Skip to content

Pretty printer algorithm revamp step 2 #93065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 20, 2022
Merged

Pretty printer algorithm revamp step 2 #93065

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fdb95f5
Inline Printer's advance_right method
dtolnay Jan 19, 2022
e219b2b
Inline Printer's scan_push method
dtolnay Jan 19, 2022
50d722a
Simplify ring buffer pushes
dtolnay Jan 19, 2022
e20d5ab
Inline Printer's scan_pop method
dtolnay Jan 19, 2022
2a14275
Inline Printer's scan_top method
dtolnay Jan 19, 2022
ae28ec5
Inline Printer's scan_pop_bottom method
dtolnay Jan 19, 2022
80139a0
Ensure Printer buf is always indexed using self.left or self.right
dtolnay Jan 19, 2022
947a09a
Replace `if` + `unwrap` with `if let` in check_stack
dtolnay Jan 19, 2022
0490e43
Implement check_stream nonrecursively
dtolnay Jan 19, 2022
a37d272
Implement check_stack nonrecursively
dtolnay Jan 19, 2022
377c9db
Index a single time in check_stack
dtolnay Jan 19, 2022
fe5c4ea
Eliminate a check_stack call on an empty scan stack
dtolnay Jan 19, 2022
6e8b060
Simplify the buffer push done by scan_break
dtolnay Jan 19, 2022
cc66a7f
Eliminate eof token state
dtolnay Jan 19, 2022
4d3faae
Eliminate left and right cursors in favor of ring buffer
dtolnay Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline Printer's scan_push method
  • Loading branch information
@dtolnay
dtolnay committed Jan 19, 2022
commit e219b2b5f90bf48bf56533c16745f2ce85216a2c
14 changes: 6 additions & 8 deletions compiler/rustc_ast_pretty/src/pp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ impl Printer {
self.right += 1;
self.buf.advance_right();
}
self.scan_push(BufEntry { token: Token::Begin(b), size: -self.right_total });
self.buf[self.right] = BufEntry { token: Token::Begin(b), size: -self.right_total };
self.scan_stack.push_front(self.right);
}

fn scan_end(&mut self) {
Expand All @@ -302,7 +303,8 @@ impl Printer {
} else {
self.right += 1;
self.buf.advance_right();
self.scan_push(BufEntry { token: Token::End, size: -1 });
self.buf[self.right] = BufEntry { token: Token::End, size: -1 };
self.scan_stack.push_front(self.right);
}
}

Expand All @@ -317,7 +319,8 @@ impl Printer {
self.buf.advance_right();
}
self.check_stack(0);
self.scan_push(BufEntry { token: Token::Break(b), size: -self.right_total });
self.buf[self.right] = BufEntry { token: Token::Break(b), size: -self.right_total };
self.scan_stack.push_front(self.right);
self.right_total += b.blank_space;
}

Expand Down Expand Up @@ -347,11 +350,6 @@ impl Printer {
}
}

fn scan_push(&mut self, entry: BufEntry) {
self.buf[self.right] = entry;
self.scan_stack.push_front(self.right);
}

fn scan_pop(&mut self) -> usize {
self.scan_stack.pop_front().unwrap()
}
Expand Down