Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple needs-asm-support headers to tests #92405

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 29, 2021

This will allow them to be ignored by codegen backends that don't support inline asm.

This will allow them to be ignored by codegen backends that don't
support inline asm.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021
@lqd
Copy link
Member

lqd commented Dec 31, 2021

Does this annotation need to be added to more tests ? Seems like a bunch of build/run tests using asm!, global_asm, and llvm_asm! could use it, right ? (and there are few like this that are not marked needs-asm-support)

r? @lqd
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2021

📌 Commit 59bf63b has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 31, 2021

Yeah, there are probably a lot more tests that need this.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90383 (Extend check for UnsafeCell in consts to cover unions)
 - rust-lang#91375 (config.rs: Add support for a per-target default_linker option.)
 - rust-lang#91480 (rustdoc: use smaller number of colors to distinguish items)
 - rust-lang#92338 (Add try_reserve and  try_reserve_exact for OsString)
 - rust-lang#92405 (Add a couple needs-asm-support headers to tests)
 - rust-lang#92435 (Sync rustc_codegen_cranelift)
 - rust-lang#92440 (Fix mobile toggles position)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81f5dbd into rust-lang:master Jan 1, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 1, 2022
@bjorn3 bjorn3 deleted the more_needs_inline_asm branch February 12, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants