Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have workcache::test clean up after itself. #9204

Closed
wants to merge 1 commit into from

Conversation

lkuper
Copy link
Contributor

@lkuper lkuper commented Sep 15, 2013

This just removes the stray "foo.c" that workcache::test leaves behind when, for example, make check runs.

@alexcrichton
Copy link
Member

Can you do this in a finally block actually? That would ensure that even if a failure occurs that the file gets removed. Another possibility would be removing it in a destructor, so many possibilities!

This prevents a stray `foo.c` from being left lying around after tests
run, and it's more consistent with the rest of the code.
@lkuper
Copy link
Contributor Author

lkuper commented Sep 16, 2013

@alexcrichton OK, I just updated the patch to yet another possibility: just have the test put foo.c (and foo.o as well) in the same directory it's running in (i.e., the build directory), which was what was already happening with db.json. This solves the problem of having stray files left in one's working copy, and it's more consistent. (It turns out the foo.o was there in my working copy before, too, but I didn't notice it because it was gitignored.)

bors added a commit that referenced this pull request Sep 16, 2013
This just removes the stray "foo.c" that `workcache::test` leaves behind when, for example, `make check` runs.
@bors bors closed this Sep 16, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 28, 2022
Check for `todo!` on every expression in `SpanlessEq`

fixes rust-lang#9204
changelog: [`match_same_arms`](https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms): Don't lint on arms with `todo!`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants