Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 iffy pull requests #91455

Merged
merged 12 commits into from
Dec 2, 2021
Merged

Commits on Nov 30, 2021

  1. Configuration menu
    Copy the full SHA
    e9bc25d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b221c87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    971c549 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Enable svh tests on msvc

    ChrisDenton committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    a8e1ac9 View commit details
    Browse the repository at this point in the history
  2. Disallow non-c-like but "fieldless" ADTs from being casted to integer...

    ... if they use arbitrary enum discriminant. Code like
    
    ```rust
    enum Enum {
        Foo = 1,
        Bar(),
        Baz{}
    }
    ```
    
    seems to be unintentionally allowed so we couldn't disallow them now,
    but we could disallow them if arbitrary enum discriminant is used before
    1.56 hits stable.
    nbdd0121 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    f7ef1c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10b3a57 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    62f4ce9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2ca9333 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Rollup merge of rust-lang#89234 - nbdd0121:discr, r=jackh726

    Disallow non-c-like but "fieldless" ADTs from being casted to integer if they use arbitrary enum discriminant
    
    Code like
    
    ```rust
    #[repr(u8)]
    enum Enum {
        Foo /* = 0 */,
        Bar(),
        Baz{}
    }
    
    let x = Enum::Bar() as u8;
    ```
    
    seems to be unintentionally allowed so we couldn't disallow them now ~~, but we could disallow them if arbitrary enum discriminant is used before 1.56 hits stable~~ (stabilization was reverted).
    
    Related: rust-lang#88621
    
    `@rustbot` label +T-lang
    matthiaskrgr authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    0666a33 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#91045 - mjptree:issue-90702-fix, r=petroche…

    …nkov
    
    Issue 90702 fix: Stop treating some crate loading failures as fatal errors
    
    Surface mulitple `extern crate` resolution errors at a time.
    
    This is achieved by creating a dummy crate, instead of aborting directly after the resolution error. The `ExternCrateError` has been added to allow propagating the resolution error from `rustc_metadata` crate to the `rustc_resolve` with a minimal public surface. The `import_extern_crate` function is a block that was factored out from `build_reduced_graph_for_item` for better organization. The only added functionality made to it where the added error handling in the `process_extern_crate` call. The remaining bits in this function are the same as before.
    
    Resolves rust-lang#90702
    
    r? `@petrochenkov`
    matthiaskrgr authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    87ca333 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#91394 - Mark-Simulacrum:bump-stage0, r=piet…

    …roalbini
    
    Bump stage0 compiler
    
    r? `@pietroalbini` (or anyone else)
    matthiaskrgr authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d96ce3e View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#91411 - ChrisDenton:valid-paths, r=petroche…

    …nkov
    
    Enable svh tests on msvc
    
    These tests were ignored for msvc in rust-lang#30778 because of additional notes that were being added for some reason. I'm fairly confident this has been fixed in the intervening years so lets try re-enabling these tests.
    
    Fixes rust-lang#31306
    matthiaskrgr authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    822a058 View commit details
    Browse the repository at this point in the history