Skip to content

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented Nov 9, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 9, 2021
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2021
@michaelwoerister
Copy link
Member

Thanks, @pierwill!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 11, 2021

📌 Commit 6f13bdb has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 11, 2021
Remove `rustc_incremental::persist::fs::dep_graph_path_from`

Closes rust-lang#90658.

r? `@michaelwoerister`
the8472 added a commit to the8472/rust that referenced this pull request Nov 11, 2021
Remove `rustc_incremental::persist::fs::dep_graph_path_from`

Closes rust-lang#90658.

r? ``@michaelwoerister``
@bors
Copy link
Collaborator

bors commented Nov 12, 2021

⌛ Testing commit 6f13bdb with merge e4c23da...

@bors
Copy link
Collaborator

bors commented Nov 12, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing e4c23da to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 12, 2021
@bors bors merged commit e4c23da into rust-lang:master Nov 12, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 12, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e4c23da): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@pierwill pierwill deleted the fix-90658 branch December 8, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing rustc_incremental::persist::fs::dep_graph_path_from
7 participants