Skip to content

rustdoc: Use conditional for _stripped fold #90574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

rustdoc: Use conditional for _stripped fold #90574

merged 1 commit into from
Nov 5, 2021

Conversation

notriddle
Copy link
Contributor

Followup: #90475 (comment)

@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2021
@notriddle
Copy link
Contributor Author

r? @camelid

@camelid
Copy link
Member

camelid commented Nov 4, 2021

r=camelid,GuillaumeGomez with CI passing

@bors rollup=never

@camelid
Copy link
Member

camelid commented Nov 4, 2021

@bors r=camelid,GuillaumeGomez rollup=never

(rollup=never because this may affect perf)

@bors
Copy link
Collaborator

bors commented Nov 4, 2021

📌 Commit 7f26883 has been approved by camelid,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021
@camelid camelid added I-compiletime Issue: Problems and improvements with respect to compile times. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 4, 2021
@bors
Copy link
Collaborator

bors commented Nov 5, 2021

⌛ Testing commit 7f26883 with merge a6162f6...

@bors
Copy link
Collaborator

bors commented Nov 5, 2021

☀️ Test successful - checks-actions
Approved by: camelid,GuillaumeGomez
Pushing a6162f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2021
@bors bors merged commit a6162f6 into rust-lang:master Nov 5, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 5, 2021
@notriddle notriddle deleted the notriddle/doc-fold-stripped-conditional branch November 5, 2021 04:42
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a6162f6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@camelid
Copy link
Member

camelid commented Nov 5, 2021 •
edited
Loading

Hmm, this change actually caused some minor regressions (~0.05% and ~0.10%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
I-compiletime Issue: Problems and improvements with respect to compile times. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@notriddle @rust-highfive @camelid @bors @rust-timer @GuillaumeGomez @rustbot