Code

Update Clippy#90126

Code

Merged

bors merged 138 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Oct 22, 2021

Commits

Commits on Oct 6, 2021

• make test module detection more strict

  llogiq

  committed
  86811e9

  Copy full SHA for 86811e9

Commits on Oct 7, 2021

• Make `shadow_reuse` suggestion less verbose

  dswij

  committed
  64f8b9d

  Copy full SHA for 64f8b9d

• Merge commit 'b7f3f7f6082679da2da9a0b3faf1b5adef3afd3b' into clippyup

  flip1995

  committed
  5cf4984

  Copy full SHA for 5cf4984

• Auto merge of #7779 - rust-lang:test_module, r=flip1995

  Show description for a04a7cd
  bors

  committed
  a04a7cd

  Copy full SHA for a04a7cd

• Auto merge of #7782 - dswij:shadow-unrelated-block, r=flip1995

  Show description for 872f321
  bors

  committed
  872f321

  Copy full SHA for 872f321

• Restriction lint for function pointer casts

  

  michaelsproul

  authored and

  camsteffen

  committed
  fbd0fb9

  Copy full SHA for fbd0fb9

• Auto merge of #7705 - michaelsproul:fn_to_numeric_cast_any, r=camsteffen

  Show description for 8aff5dd
  bors

  committed
  8aff5dd

  Copy full SHA for 8aff5dd

• Add undocumented_unsafe_blocks lint

  Serial-ATA

  committed
  412b862

  Copy full SHA for 412b862

Commits on Oct 8, 2021

• Auto merge of #7748 - Serial-ATA:lint-undocumented-unsafe, r=flip1995

  Show description for 78e7312
  bors

  committed
  78e7312

  Copy full SHA for 78e7312

• Do not expand macros in equatable_if_let suggestion

  flip1995

  committed
  28fb591

  Copy full SHA for 28fb591

• Don't trigger semicolon_if_nothing_returned in expanded code

  Show description for b423b85
  flip1995

  committed
  b423b85

  Copy full SHA for b423b85

• Allow giving reasons for `disallowed_types`

  Show description for 72078fa
  

  JamesHinshelwood

  and

  james-bigpay

  committed
  72078fa

  Copy full SHA for 72078fa

• Auto merge of #7789 - flip1995:double_semi_if_nothing_returned, r=camsteffen

  Show description for 22144c0
  bors

  committed
  22144c0

  Copy full SHA for 22144c0

Commits on Oct 9, 2021

• Add `--msrv` option to `new_lint` command

  

  Michael Wright

  committed
  da76c06

  Copy full SHA for da76c06

• Fix `clippy::too-many-arguments` violation

  

  Michael Wright

  committed
  b878225

  Copy full SHA for b878225

• Use `indoc` for formatting

  

  Michael Wright

  committed
  7d9b21b

  Copy full SHA for 7d9b21b

• Implement uninit_vec lint

  Qwaz

  committed
  452181c

  Copy full SHA for 452181c

• Fix clippy lints

  Qwaz

  committed
  b8ba726

  Copy full SHA for b8ba726

• Handle PR feedbacks first round

  Qwaz

  committed
  759200b

  Copy full SHA for 759200b

• Improve error messages

  Qwaz

  committed
  fdc06d9

  Copy full SHA for fdc06d9

• Add #allow attribute to suppress FP #7698

  Qwaz

  committed
  fec20bf

  Copy full SHA for fec20bf

• Extract get_vec_init_kind and share it

  Qwaz

  committed
  dd9c8d3

  Copy full SHA for dd9c8d3

• Address PR comments

  Qwaz

  committed
  b1aa306

  Copy full SHA for b1aa306

• Add testcases

  Qwaz

  committed
  de0d2b1

  Copy full SHA for de0d2b1

• Improved error message for set_len() on empty Vec

  Qwaz

  committed
  2181387

  Copy full SHA for 2181387

• Address internal lints

  Qwaz

  committed
  03fed75

  Copy full SHA for 03fed75

• Fix false positive when `Drop` and `Copy` involved

  ThibsG

  committed
  7aaed02

  Copy full SHA for 7aaed02

• Auto merge of #7794 - ThibsG:FieldReassignDefault6312, r=llogiq

  Show description for 8f1555f
  bors

  committed
  8f1555f

  Copy full SHA for 8f1555f

• Fix FP in external macros for `mut_mut` lint

  ThibsG

  committed
  1e18b8a

  Copy full SHA for 1e18b8a

• Refactor to check for multiple reference patterns

  1nF0rmed

  committed
  fc32425

  Copy full SHA for fc32425

Commits on Oct 10, 2021

• Adds additional tests for lint

  1nF0rmed

  committed
  1080f6c

  Copy full SHA for 1080f6c

• Auto merge of #7800 - 1nF0rmed:no-lint-in-match-single-amp, r=llogiq

  Show description for 9205e3d
  bors

  committed
  9205e3d

  Copy full SHA for 9205e3d

Commits on Oct 11, 2021

• Auto merge of #7795 - ThibsG:MutMut6922, r=giraffate

  Show description for bc9ad84
  bors

  committed
  bc9ad84

  Copy full SHA for bc9ad84

• Add reason config example for disallowed_type

  Show description for 857a407
  

  JamesHinshelwood

  and

  james-bigpay

  committed
  857a407

  Copy full SHA for 857a407

• Rename `disallowed` to `conf_disallowed`

  Show description for 886cbb1
  

  JamesHinshelwood

  and

  james-bigpay

  committed
  886cbb1

  Copy full SHA for 886cbb1

• Deprecate mem_discriminant_non_enum

  Show description for f44a904
  flip1995

  committed
  f44a904

  Copy full SHA for f44a904

• Auto merge of #7793 - mikerite:new_lint-msrv-2, r=Manishearth

  Show description for 7272366
  bors

  committed
  7272366

  Copy full SHA for 7272366

• Add #[must_use] to From::from and Into::into

  jkugelman

  committed
  44db271

  Copy full SHA for 44db271

Commits on Oct 12, 2021

• Auto merge of #7791 - JamesHinshelwood:reason-in-disallowed-type, r=giraffate

  Show description for 77dda9c
  bors

  committed
  77dda9c

  Copy full SHA for 77dda9c

• Add match_str_case_mismatch lint

  Serial-ATA

  committed
  9e0ce14

  Copy full SHA for 9e0ce14

• Don't run examples

  Serial-ATA

  committed
  99bfee7

  Copy full SHA for 99bfee7

• Bring `manual_split_once` docs in line with other lint docs

  Veykril

  authored
  5adf17c

  Copy full SHA for 5adf17c

• Auto merge of #89770 - jkugelman:must-use-from-and-into, r=joshtriplett

  Show description for 1757386
  bors

  committed
  1757386

  Copy full SHA for 1757386

• Add a suggestion

  Serial-ATA

  committed
  0c99de0

  Copy full SHA for 0c99de0

• Auto merge of #7808 - Veykril:patch-1, r=xFrednet

  Show description for 5c97b27
  bors

  committed
  5c97b27

  Copy full SHA for 5c97b27

• Auto merge of #7806 - Serial-ATA:lint-match-case-mismatch, r=llogiq

  Show description for d3905af
  bors

  committed
  d3905af

  Copy full SHA for d3905af

• Update lint description for new() and default()

  Qwaz

  committed
  4ed3a4f

  Copy full SHA for 4ed3a4f

• Auto merge of #7682 - Qwaz:uninit_vec, r=xFrednet

  Show description for 3d9c4a6
  bors

  committed
  3d9c4a6

  Copy full SHA for 3d9c4a6

Commits on Oct 13, 2021

• Update clippy ui output

  oli-obk

  committed
  049ab82

  Copy full SHA for 049ab82

• Auto merge of #7788 - flip1995:eq_if_let_sugg, r=giraffate

  Show description for 57dc034
  bors

  committed
  57dc034

  Copy full SHA for 57dc034

• Add lint transmute_num_to_bytes

  Show description for 5896980
  aDotInTheVoid

  committed
  5896980

  Copy full SHA for 5896980

• Fix typo in example for `match_result_ok`

  nhamovitz

  authored
  09aa4ad

  Copy full SHA for 09aa4ad

• Auto merge of #7805 - aDotInTheVoid:transmute-num-bits, r=camsteffen

  Show description for b9b11a9
  bors

  committed
  b9b11a9

  Copy full SHA for b9b11a9

• Auto merge of #7815 - nhamovitz:patch-1, r=giraffate

  Show description for 4996e17
  bors

  committed
  4996e17

  Copy full SHA for 4996e17

Commits on Oct 15, 2021

• Refactor overlapping arm tests

  Show description for e664a76
  

  Michael Wright

  committed
  e664a76

  Copy full SHA for e664a76

• Add unbounded pats to `match_overlapping_arm` tests

  

  Michael Wright

  committed
  28a249b

  Copy full SHA for 28a249b

• Fix clippy with changed macro statement spans

  camsteffen

  committed
  0a23fff

  Copy full SHA for 0a23fff

• `unnecessary_sort_by` only warns if argument impl `Ord` trait

  dswij

  committed
  ec50719

  Copy full SHA for ec50719

• Add test on `unnecessary_sort_by` when argument does not implement `Ord`

  dswij

  committed
  e4ac4c2

  Copy full SHA for e4ac4c2

• Auto merge of #7824 - dswij:unnecessary_sort_by, r=llogiq

  Show description for 70f36e0
  bors

  committed
  70f36e0

  Copy full SHA for 70f36e0

• Auto merge of #7823 - mikerite:match-overlapping-arm-20211015, r=xFrednet

  Show description for db403bb
  bors

  committed
  db403bb

  Copy full SHA for db403bb

• Add `format_in_format_args` and `to_string_in_format_args` lints

  Show description for c9599d7
  smoelius

  committed
  c9599d7

  Copy full SHA for c9599d7

• Fix adjacent tests

  smoelius

  committed
  47014d8

  Copy full SHA for 47014d8

• Remove redundant `to_string`s

  smoelius

  committed
  75e9f8c

  Copy full SHA for 75e9f8c

• Auto merge of #7743 - smoelius:master, r=camsteffen

  Show description for e1871ba
  bors

  committed
  e1871ba

  Copy full SHA for e1871ba

Commits on Oct 16, 2021

• Fixed naive doc formatting for `#[must_use]` lints

  zvavybir

  committed
  25ff7ce

  Copy full SHA for 25ff7ce

• Auto merge of #7827 - zvavybir:master, r=xFrednet

  Show description for d50cfd2
  bors

  committed
  d50cfd2

  Copy full SHA for d50cfd2

Commits on Oct 17, 2021

• Some "parenthesis" and "parentheses" fixes

  wooster0

  committed
  599d912

  Copy full SHA for 599d912

• Fix false positive of `implicit_saturating_sub` with `else` clause

  Show description for a550133
  narpfel

  committed
  a550133

  Copy full SHA for a550133

• Rollup merge of #89963 - r00ster91:parenthesisparentheses, r=nagisa

  Show description for 79b73ac
  matthiaskrgr

  authored
  79b73ac

  Copy full SHA for 79b73ac

• Add reference to another doc with explanation

  Show description for bdc1624
  Dmitry-Borodin

  authored
  bdc1624

  Copy full SHA for bdc1624

• rustc_span: `Ident::invalid` -> `Ident::empty`

  Show description for 5f2ecc3
  petrochenkov

  committed
  5f2ecc3

  Copy full SHA for 5f2ecc3

Commits on Oct 18, 2021

• Auto merge of #7832 - narpfel:implicit-saturating-sub-false-positive-else, r=giraffate

  Show description for af85240
  bors

  committed
  af85240

  Copy full SHA for af85240

• Rollup merge of #89990 - petrochenkov:idempty, r=wesleywiser

  Show description for e84537b
  matthiaskrgr

  authored
  e84537b

  Copy full SHA for e84537b

• Remove unneeded allow

  

  Michael Wright

  committed
  63d7152

  Copy full SHA for 63d7152

• Auto merge of #7835 - mikerite:unneeded-allow-20211018, r=xFrednet

  Show description for 389a74b
  bors

  committed
  389a74b

  Copy full SHA for 389a74b

• Add boilerplate and basic tests

  nhamovitz

  committed
  797507c

  Copy full SHA for 797507c

• Well it builds

  nhamovitz

  committed
  c69387a

  Copy full SHA for c69387a

• ayy it compiles! ship it, right? 😎 /s

  Show description for 92d3b77
  nhamovitz

  committed
  92d3b77

  Copy full SHA for 92d3b77

• Implement detecting trailing zero-sized array

  nhamovitz

  committed
  7ee8e7a

  Copy full SHA for 7ee8e7a

• Implement getting an array of attributes!

  nhamovitz

  committed
  523b013

  Copy full SHA for 523b013

• it works i think (incl some `dbg`s)

  nhamovitz

  committed
  e53a4da

  Copy full SHA for e53a4da

• output looks fantastic

  nhamovitz

  committed
  4b4db59

  Copy full SHA for 4b4db59

• Ran `dev bless`!

  nhamovitz

  committed
  b9948c4

  Copy full SHA for b9948c4

• add multiple `get_attrs` and `includes_repr` and they all work!

  nhamovitz

  committed
  003972f

  Copy full SHA for 003972f

• intermediate step

  nhamovitz

  committed
  5fdf934

  Copy full SHA for 5fdf934

• tried to simplify but it doesn't work :/

  nhamovitz

  committed
  9b3f55e

  Copy full SHA for 9b3f55e

• Tidy comments + tests; revert 'size-is-zero' detection

  nhamovitz

  committed
  a3420f7

  Copy full SHA for a3420f7

• update testsuite and expand `if_chain`

  nhamovitz

  committed
  c5d3167

  Copy full SHA for c5d3167

• Refactor ZS array detection again and this one seems great 👍

  nhamovitz

  committed
  2a5a4f0

  Copy full SHA for 2a5a4f0

• Check for tuple structs

  nhamovitz

  committed
  9f402b3

  Copy full SHA for 9f402b3

• Tidy imports

  nhamovitz

  committed
  cd68622

  Copy full SHA for cd68622

• Tidy import + update expected stderr

  nhamovitz

  committed
  6377fb2

  Copy full SHA for 6377fb2

• run rustfmt

  nhamovitz

  committed
  149b372

  Copy full SHA for 149b372

• Rename lint

  nhamovitz

  committed
  7f84e3d

  Copy full SHA for 7f84e3d

• Rename stderr

  nhamovitz

  committed
  a6aa986

  Copy full SHA for a6aa986

• Improve doc and span messages

  nhamovitz

  committed
  a54dbf6

  Copy full SHA for a54dbf6

• Still renaming lmao

  nhamovitz

  committed
  5b78907

  Copy full SHA for 5b78907

• One more test

  nhamovitz

  committed
  d25b4ee

  Copy full SHA for d25b4ee

• Better testcase names

  nhamovitz

  committed
  ab9fa25

  Copy full SHA for ab9fa25

• Exploring emitting other sorts of `span`s

  nhamovitz

  committed
  3a41f22

  Copy full SHA for 3a41f22

• All five `has_repr_attr` agree + are correct

  nhamovitz

  committed
  d8bacf0

  Copy full SHA for d8bacf0

• Improve help message

  nhamovitz

  committed
  18c863d

  Copy full SHA for 18c863d

• Don't need `rustc_attr` anymore

  nhamovitz

  committed
  48cf9c2

  Copy full SHA for 48cf9c2

Commits on Oct 19, 2021

• !: this is the commit that demonstrates the ICE

  nhamovitz

  committed
  d85f903

  Copy full SHA for d85f903

• Revert "!: this is the commit that demonstrates the ICE"

  Show description for 6303d2d
  nhamovitz

  committed
  6303d2d

  Copy full SHA for 6303d2d

• One more test + final tidying

  nhamovitz

  committed
  c654cc5

  Copy full SHA for c654cc5

• Remove comment

  nhamovitz

  committed
  bc32be0

  Copy full SHA for bc32be0

• Remove explicit lifetime

  nhamovitz

  committed
  02b1f26

  Copy full SHA for 02b1f26

• Use real type in doc examples

  nhamovitz

  committed
  4c8e816

  Copy full SHA for 4c8e816

• formatting 🙃

  nhamovitz

  committed
  5283d24

  Copy full SHA for 5283d24

• Cover `Result` for `question_mark`

  dswij

  committed
  687f392

  Copy full SHA for 687f392

• Update test for `question_mark` to cover `Result`

  dswij

  committed
  3fc99b6

  Copy full SHA for 3fc99b6

• Remove begin_panic_fmt from clippy

  nbdd0121

  committed
  ebf4f03

  Copy full SHA for ebf4f03

• made description of intellij a link by moving outside of code block.

  Dmitry-Borodin

  committed
  7246731

  Copy full SHA for 7246731

• avoid `eq_op` in test code

  llogiq

  committed
  e88c956

  Copy full SHA for e88c956

• Rollup merge of #88860 - nbdd0121:panic, r=m-ou-se

  Show description for 30cc96e
  JohnTitor

  authored
  30cc96e

  Copy full SHA for 30cc96e

• Auto merge of #7811 - rust-lang:eq-op-testless, r=xFrednet

  Show description for c1e7a07
  bors

  committed
  c1e7a07

  Copy full SHA for c1e7a07

• remove resolved note

  nhamovitz

  committed
  60da4c9

  Copy full SHA for 60da4c9

• Rename lint

  nhamovitz

  committed
  0f9f591

  Copy full SHA for 0f9f591

• Lint on underscore variable assignment

  Show description for 6b22bba
  F3real

  committed
  6b22bba

  Copy full SHA for 6b22bba

• Auto merge of #7833 - Dmitry-Borodin:patch-1, r=giraffate

  Show description for 5bdd2ce
  bors

  committed
  5bdd2ce

  Copy full SHA for 5bdd2ce

Commits on Oct 20, 2021

• Small refactor on `question_mark` condition checks

  dswij

  committed
  083a454

  Copy full SHA for 083a454

• Auto merge of #7840 - dswij:question-mark-result, r=llogiq

  Show description for ee8c155
  bors

  committed
  ee8c155

  Copy full SHA for ee8c155

• Auto merge of #7775 - F3real:no_effect, r=xFrednet

  Show description for 06722c0
  bors

  committed
  06722c0

  Copy full SHA for 06722c0

• Fix doc heading of TRANSMUTE_NUM_TO_BYTES

  Veykril

  authored
  9cf68e4

  Copy full SHA for 9cf68e4

• Auto merge of #7848 - Veykril:patch-1, r=xFrednet

  Show description for 76150a4
  bors

  committed
  76150a4

  Copy full SHA for 76150a4

• Do not lint if any parent has hidden attribute

  ThibsG

  committed
  3630afb

  Copy full SHA for 3630afb

• Auto merge of #7849 - ThibsG:SafetyDoc, r=llogiq

  Show description for f11905a
  bors

  committed
  f11905a

  Copy full SHA for f11905a

• Auto merge of #7838 - nhamovitz:trailing_zs_arr_wo_repr, r=Manishearth

  Show description for 300b821
  bors

  committed
  300b821

  Copy full SHA for 300b821

Commits on Oct 21, 2021

• Fix typo for INVALID_NULL_PTR_USAGE and MISSING_INLINE_IN_PUBLIC_ITEMS.

  surechen

  committed
  abb7ae9

  Copy full SHA for abb7ae9

• Auto merge of #7852 - surechen:fix_typo, r=xFrednet

  Show description for 535262c
  bors

  committed
  535262c

  Copy full SHA for 535262c

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  085181e

  Copy full SHA for 085181e

• Bump Clippy Version -> 0.1.58

  flip1995

  committed
  1222330

  Copy full SHA for 1222330

• Bump nightly version -> 2021-10-21

  flip1995

  committed
  8e48333

  Copy full SHA for 8e48333

• Auto merge of #7853 - flip1995:rustup, r=flip1995

  Show description for 91496c2
  bors

  committed
  91496c2

  Copy full SHA for 91496c2

• Merge commit '91496c2ac6abf6454c413bb23e8becf6b6dc20ea' into clippyup

  flip1995

  committed
  9af8e37

  Copy full SHA for 9af8e37

• Update Cargo.lock

  flip1995

  committed
  8d5f69d

  Copy full SHA for 8d5f69d