Add #[must_use] to remaining core functions#89897
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 31, 2021
Merged
Conversation
5fdde08 to
d40f562
Compare
Member
|
I left a comment on two functions that I think should not have |
d40f562 to
68b0d86
Compare
Contributor
Author
|
@joshtriplett What does |
Member
|
@jkugelman If someone says "r=me with xyz fixed", that means "anyone with permission who comes along later is welcome to |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 68b0d86 has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…lett Add #[must_use] to remaining core functions I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the `core` crate. Ignored by clippy for reasons unknown: ```rust core::alloc::Layout unsafe fn for_value_raw<T: ?Sized>(t: *const T) -> Self; core::any const fn type_name_of_val<T: ?Sized>(_val: &T) -> &'static str; ``` Ignored by clippy because of `mut`: ```rust str fn split_at_mut(&mut self, mid: usize) -> (&mut str, &mut str); ``` <del> Ignored by clippy presumably because a caller might want `f` called for side effects. That seems like a bad usage of `map` to me. ```rust core::cell::Ref<'b, T> fn map<U: ?Sized, F>(orig: Ref<'b, T>, f: F) -> Ref<'b, T>; core::cell::Ref<'b, T> fn map_split<U: ?Sized, V: ?Sized, F>(orig: Ref<'b, T>, f: F) -> (Ref<'b, U>, Ref<'b, V>); ``` </del> Parent issue: rust-lang#89692 r? `@joshtriplett`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…lett Add #[must_use] to remaining core functions I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the `core` crate. Ignored by clippy for reasons unknown: ```rust core::alloc::Layout unsafe fn for_value_raw<T: ?Sized>(t: *const T) -> Self; core::any const fn type_name_of_val<T: ?Sized>(_val: &T) -> &'static str; ``` Ignored by clippy because of `mut`: ```rust str fn split_at_mut(&mut self, mid: usize) -> (&mut str, &mut str); ``` <del> Ignored by clippy presumably because a caller might want `f` called for side effects. That seems like a bad usage of `map` to me. ```rust core::cell::Ref<'b, T> fn map<U: ?Sized, F>(orig: Ref<'b, T>, f: F) -> Ref<'b, T>; core::cell::Ref<'b, T> fn map_split<U: ?Sized, V: ?Sized, F>(orig: Ref<'b, T>, f: F) -> (Ref<'b, U>, Ref<'b, V>); ``` </del> Parent issue: rust-lang#89692 r? ``@joshtriplett``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2021
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89446 (Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)) - rust-lang#89677 (Stabilize `is_symlink()` for `Metadata` and `Path`) - rust-lang#89833 (Add #[must_use] to Rc::downgrade) - rust-lang#89835 (Add #[must_use] to expensive computations) - rust-lang#89839 (Add #[must_use] to mem/ptr functions) - rust-lang#89897 (Add #[must_use] to remaining core functions) - rust-lang#89951 (Stabilize `option_result_unwrap_unchecked`) - rust-lang#90427 (Add #[must_use] to alloc functions that would leak memory) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the
corecrate.Ignored by clippy for reasons unknown:
Ignored by clippy because of
mut:Ignored by clippy presumably because a caller might want `f` called for side effects. That seems like a bad usage of `map` to me.
Parent issue: #89692
r? @joshtriplett