Add tests for some const generics issues #88602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
hellow554
reviewed
Sep 3, 2021
|
|
||
| fn pop(self) -> (Self::Newlen, Self::Output) { | ||
| let mut iter = IntoIter::new(self); | ||
| //~^ ERROR: failed to resolve: use of undeclared type `IntoIter` |
There was a problem hiding this comment.
Does importing the trait break the ICE? If not wouldn't be including it easier for this testcase?
There was a problem hiding this comment.
I'm honestly not sure if it would cause this to not repro the ICE or not. I don't really have a way of verifying...
|
@bors r+ rollup |
|
📌 Commit 89c6d4f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#88602 (Add tests for some const generics issues) - rust-lang#88647 (Document when to use Windows' `symlink_dir` vs. `symlink_file`) - rust-lang#88659 (Remove SmallVector mention) - rust-lang#88661 (Correct typo) - rust-lang#88673 (Fix typo: needede -> needed) - rust-lang#88685 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #82956
closes #84659
closes #86530
closes #86535
there is also a random test in here about array repeat expressions that I already had on this branch but it seems to fit the theme of this PR so kept it...
r? @lcnr