Rollup of 9 pull requests #87640
Merged
Rollup of 9 pull requests #87640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when struct is generic
…agisa Cross compiling rustc_llvm on Darwin requires zlib.
…ochenkov Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default This PR makes the `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` lint warn by default. To avoid showing a large number of un-actionable warnings to users, we only enable the lint for macros defined in the same crate. This ensures that users will be able to fix the warning by simply removing a semicolon. In the future, I'd like to enable this lint unconditionally, and eventually make it into a hard error in a future edition. This PR is a step towards that goal.
…kennytm Add missing examples for NonNull
…-error, r=nikomatsakis Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic Fixes rust-lang#86940 The test cases and associated issue should make it clear what specifically this is meant to fix. The fix is slightly hacky in that we check against the literal source code of the call site for the presence of `<` in order to determine if the user has included the generics for the struct (meaning we don't need to include them for them). r? ``@nikomatsakis``
Tweak borrowing suggestion in `for` loop
…ce, r=estebank Add warning when whitespace is not skipped after an escaped newline Fixes issue rust-lang#87318, also simplifies issue rust-lang#87319. * Add support to the lexer to emit warnings as well as errors. * Emit a warning when a string literal contains an escaped newline, but when (some of) the whitespace on the next line is not skipped due to it being non-ASCII.
Add some TAIT-related regression tests Closes rust-lang#74280, closes rust-lang#77179. r? ``@oli-obk``
…ocs, r=m-ou-se Add docs about performance and `Iterator::map` to `[T; N]::map` This suboptimal code gen for some usages of array::map got a bit of attention by multiple people throughout the community. Some cases: - rust-lang#75243 (comment) - rust-lang#75243 (comment) - https://www.reddit.com/r/rust/comments/oeqqf7/unexpected_high_stack_usage/ My *guess* is that this gets the attention it gets because in JavaScript (and potentially other languages), a `map` function on arrays is very commonly used since in those languages, arrays basically take the role of Rust's iterator. I considered explicitly naming JavaScript in the first paragraph I added, but I couldn't find precedence of mentioning other languages in standard library doc, so I didn't add it. When array::map was stabilized, we still wanted to add docs, but that somehow did not happen in time. So here we are. Not sure if this sounds crazy but maybe it is worth considering beta backporting this? Only if it's not a lot of work, of course! But yeah, stabilized array::map is already in beta and if this problem is really as big as it sometimes seems, might be worth having the docs in place when 1.55 is released. CC ``@CryZe`` r? ``@m-ou-se`` (since you were involved in that discussion and the stabilization)
Fix missing word in rustdoc book
|
@bors r+ p=9 rollup=never |
|
📌 Commit 8d5291c has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
This PR caused a moderate perf regression on several benchmarks; I'm not sure which PR in this rollup is responsible. None jump out as immediately suspicious. Marking as perf-regression to add to the list of untriaged regressions. |
|
Checking locally it looks like #87385 generates ~60 new warnings for html5ever, which is presumably ~entirely the cause of the regression for that benchmark. Other benchmarks don't show warning differences but cachegrind isn't showing conclusive evidence of changes in either direction so I'm inclined to say that they're not a concrete change that we can address. Marking as triaged. @rustbot label perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
SEMICOLON_IN_EXPRESSIONS_FROM_MACROSwarn by default #87385 (MakeSEMICOLON_IN_EXPRESSIONS_FROM_MACROSwarn by default)forloop #87559 (Tweak borrowing suggestion inforloop)Iterator::mapto[T; N]::map#87609 (Add docs about performance andIterator::mapto[T; N]::map)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup