stack overflow handler specific openbsd change. #87528

devnexen · 2021-07-27T21:38:34Z

No description provided.

rust-highfive · 2021-07-27T21:38:37Z

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-07-27T21:54:51Z

library/std/src/sys/unix/stack_overflow.rs

@@ -143,11 +143,17 @@ mod imp {
    }

    unsafe fn get_stackp() -> *mut libc::c_void {
+        #[cfg(target_os = "openbsd")]
+        let flags = MAP_PRIVATE | MAP_ANON | libc::MAP_STACK;
+        // OpenBSD requires this flag for stack mapping


"this flag" is referring to MAP_STACK? If so the comment is on the wrong line.

the8472 · 2021-07-27T21:59:51Z

The PR title and description could use some improvement. After all every commit implicitly is a change. And why is it needed? Is OpenBSD broken without it or is it only a correctness fix that currently doesn't make a difference but may do so in the future? If it's the latter shouldn't it also be applied on linux since the manpage there says that

However, by employing this flag, applications can ensure that they transparently obtain support if the flag is implemented in the future.

bjorn3 · 2021-07-28T11:52:26Z

library/std/src/sys/unix/stack_overflow.rs

-            0,
-        );
+        // OpenBSD requires this flag for stack mapping
+        // otherwise the said mapping will fail is a no-op in most systems


s/in/on
reads nicer I think.

bjorn3 · 2021-07-28T11:58:10Z

library/std/src/sys/unix/stack_overflow.rs

+        #[cfg(target_os = "openbsd")]
+        let flags = MAP_PRIVATE | MAP_ANON | libc::MAP_STACK;
+        #[cfg(not(target_os = "openbsd"))]
+        let flags = MAP_PRIVATE | MAP_ANON;


Linux supports MAP_STACK too. It is a no-op on all architectures. FreeBSD supports it too. For example macOS doesn't support it though.

yes but not necessary on these oses plus solaris/illumos does not have it and I believe haiku neither.

yes but not necessary

Not currently necessary. A future architecture may need it. That is why it exists as no-op at all.

ok can add for linux, netbsd but I m less sure about FreeBSD the flag is working but does not seem to work well with null start addresses, seems little usage difference.

On this platform, when doing stack allocation, MAP_STACK is needed otherwise the mapping fails.

joshtriplett · 2021-10-04T02:39:20Z

Seems reasonable, and consistent with the OpenBSD documentation.

@bors r+

bors · 2021-10-04T02:39:21Z

📌 Commit 853ffc7 has been approved by joshtriplett

stack overflow handler specific openbsd change.

workingjubilee · 2021-10-04T20:55:32Z

Appears to not work with all Unix libcs? #89529

[RUSTC-TIMING] addr2line test:false 0.596
[RUSTC-TIMING] core test:false 27.851
[RUSTC-TIMING] gimli test:false 6.055
[RUSTC-TIMING] object test:false 6.197
error[E0425]: cannot find value `MAP_STACK` in crate `libc`
   --> library/std/src/sys/unix/stack_overflow.rs:150:52
    |
150 |         let flags = MAP_PRIVATE | MAP_ANON | libc::MAP_STACK;
    |                                                    ^^^^^^^^^ not found in `libc`
For more information about this error, try `rustc --explain E0425`.
[RUSTC-TIMING] std test:false 2.972
error: could not compile `std` due to previous error
Build completed unsuccessfully in 0:06:57

@bors r-

devnexen · 2021-10-04T21:02:33Z

it might needs a libc update ... it is present since the 0.2.102 release (or updating the current PR to not enabling on netbsd).

devnexen · 2021-10-04T21:13:47Z

having lost the original repo since, I opted for libc update, anyway it would have been needed at some point.

to solve rust-lang#87528 build.

…d, r=dtolnay library std, libc dependency update to solve rust-lang#87528 build.

JohnTitor · 2021-10-07T00:00:52Z

The libc dependency now has been updated, @bors r=joshtriplett

bors · 2021-10-07T00:00:53Z

📌 Commit 853ffc7 has been approved by joshtriplett

stack overflow handler specific openbsd change.

…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#75644 (Add 'core::array::from_fn' and 'core::array::try_from_fn') - rust-lang#87528 (stack overflow handler specific openbsd change.) - rust-lang#88436 (std: Stabilize command_access) - rust-lang#89614 (Update to Unicode 14.0) - rust-lang#89664 (Add documentation to boxed conversions) - rust-lang#89700 (Fix invalid HTML generation for higher bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned joshtriplett Jul 27, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2021

This comment has been minimized.

Sign in to view

the8472 reviewed Jul 27, 2021

View reviewed changes

bjorn3 reviewed Jul 28, 2021

View reviewed changes

stack overflow handler specific openbsd fix.

853ffc7

On this platform, when doing stack allocation, MAP_STACK is needed otherwise the mapping fails.

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021

inquisitivecrystal added T-libs Relevant to the library team, which will review and decide on the PR/issue. O-openbsd Operating system: OpenBSD labels Aug 24, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 4, 2021

Rollup merge of rust-lang#87528 - :stack_overflow_obsd, r=joshtriplett

3a65912

stack overflow handler specific openbsd change.

Manishearth mentioned this pull request Oct 4, 2021

Rollup of 14 pull requests #89529

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2021

devnexen mentioned this pull request Oct 4, 2021

library std, libc dependency update #89531

Merged

devnexen added a commit to devnexen/rust that referenced this pull request Oct 5, 2021

library std, libc dependency update

c79447e

to solve rust-lang#87528 build.

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 6, 2021

Rollup merge of rust-lang#89531 - devnexen:stack_overflow_bsd_libc_up…

fd3f945

…d, r=dtolnay library std, libc dependency update to solve rust-lang#87528 build.

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 6, 2021

Rollup merge of rust-lang#89531 - devnexen:stack_overflow_bsd_libc_up…

79a1fc8

…d, r=dtolnay library std, libc dependency update to solve rust-lang#87528 build.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2021

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 8, 2021

Rollup merge of rust-lang#87528 - :stack_overflow_obsd, r=joshtriplett

bc70f7d

stack overflow handler specific openbsd change.

GuillaumeGomez mentioned this pull request Oct 8, 2021

Rollup of 6 pull requests #89671

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 9, 2021

Rollup merge of rust-lang#87528 - :stack_overflow_obsd, r=joshtriplett

41babca

stack overflow handler specific openbsd change.

This was referenced Oct 9, 2021

Rollup of 7 pull requests #89702

Closed

Rollup of 6 pull requests #89703

Merged

bors merged commit 3e4f956 into rust-lang:master Oct 9, 2021

rustbot added this to the 1.57.0 milestone Oct 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stack overflow handler specific openbsd change. #87528

stack overflow handler specific openbsd change. #87528

devnexen commented Jul 27, 2021

rust-highfive commented Jul 27, 2021

This comment has been minimized.

the8472 Jul 27, 2021

devnexen Jul 27, 2021

the8472 commented Jul 27, 2021

bjorn3 Jul 28, 2021

bjorn3 Jul 28, 2021

devnexen Jul 28, 2021

bjorn3 Jul 28, 2021

devnexen Jul 28, 2021

bjorn3 Jul 28, 2021

devnexen Jul 28, 2021

joshtriplett commented Oct 4, 2021

bors commented Oct 4, 2021

workingjubilee commented Oct 4, 2021 •

edited

Loading

devnexen commented Oct 4, 2021

devnexen commented Oct 4, 2021

JohnTitor commented Oct 7, 2021

bors commented Oct 7, 2021

stack overflow handler specific openbsd change. #87528

stack overflow handler specific openbsd change. #87528

Conversation

devnexen commented Jul 27, 2021

rust-highfive commented Jul 27, 2021

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

the8472 commented Jul 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshtriplett commented Oct 4, 2021

bors commented Oct 4, 2021

workingjubilee commented Oct 4, 2021 • edited Loading

devnexen commented Oct 4, 2021

devnexen commented Oct 4, 2021

JohnTitor commented Oct 7, 2021

bors commented Oct 7, 2021

workingjubilee commented Oct 4, 2021 •

edited

Loading