Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar display on small devices #87167

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

GuillaumeGomez
Copy link
Member

Part of #87059.

Instead of hiding the sidebar on small devices, we instead move it out of the viewport so that it remains "visible" to our text only users.

Could you confirm it works for you @ahicks92 and @DataTriny please? You can give it a try at this URL.

r? @notriddle

@GuillaumeGomez GuillaumeGomez changed the title Fix idebar display on small devices Fix sidebar display on small devices Jul 15, 2021
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 15, 2021
@notriddle
Copy link
Contributor

We also want to make sure this works well for sighted people using the keyboard to navigate.

The obvious way to do that is to have JavaScript detect when focus goes inside the sidebar, and make the sidebar visible when it does.

@GuillaumeGomez
Copy link
Member Author

I don't expect sighted people to have a screen small enough to get the sidebar moved out of the viewport.

@notriddle
Copy link
Contributor

B37A8FEA-ED70-4CFC-AA65-C720E645934A

@GuillaumeGomez
Copy link
Member Author

😮 Ok nevermind. Please open an issue so I can do it next. 🤣

@notriddle
Copy link
Contributor

@GuillaumeGomez #87172

@notriddle
Copy link
Contributor

Other than that concern, this seems fine to me.

@ahicks92
Copy link
Contributor

NVDA is claiming it's at -19% from the left of the screen, so going with yes.

@GuillaumeGomez
Copy link
Member Author

@ahicks92 Awesome, thanks!

Once this PR is merged, I'll write the PR about the focus.

@bors: r=notriddle

@bors
Copy link
Contributor

bors commented Jul 16, 2021

📌 Commit 868ffd0 has been approved by notriddle

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 16, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#86983 (Add or improve natvis definitions for common standard library types)
 - rust-lang#87069 (ExprUseVisitor: Treat ByValue use of Copy types as ImmBorrow)
 - rust-lang#87138 (Correct invariant documentation for `steps_between`)
 - rust-lang#87145 (Make --cap-lints and related options leave crate hash alone)
 - rust-lang#87161 (RFC2229: Use the correct place type)
 - rust-lang#87162 (Fix type decl layout "overflow")
 - rust-lang#87167 (Fix sidebar display on small devices)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b19f37c into rust-lang:master Jul 16, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 16, 2021
@GuillaumeGomez GuillaumeGomez deleted the sidebar-display-mobile branch July 16, 2021 12:12
notriddle added a commit to notriddle/rust that referenced this pull request Jul 16, 2021
Fixes rust-lang#87172

Based on rust-lang#87167 (which should be merged first)

Preview it at https://notriddle.com/notriddle-rustdoc-test/std/index.html

Co-authored-by: Guillaume Gomez <guillaume.gomez@huawei.com>
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 16, 2021
…d-mobile, r=GuillaumeGomez

feat(rustdoc): open sidebar menu when links inside it are focused

Fixes rust-lang#87172

Based on rust-lang#87167 (which should be merged first)

r? `@GuillaumeGomez`

Preview it at https://notriddle.com/notriddle-rustdoc-test/std/index.html
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 16, 2021
…d-mobile, r=GuillaumeGomez

feat(rustdoc): open sidebar menu when links inside it are focused

Fixes rust-lang#87172

Based on rust-lang#87167 (which should be merged first)

r? ``@GuillaumeGomez``

Preview it at https://notriddle.com/notriddle-rustdoc-test/std/index.html
@GuillaumeGomez GuillaumeGomez added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 26, 2021
@GuillaumeGomez GuillaumeGomez added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 26, 2021
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 26, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2021
…lacrum

Prepare 1.54.0 release

This PR builds the stable artifacts for the 1.54.0 release. Backports included:

* rust-lang#86696
*  rust-lang#87167
* rust-lang#87210

I was *not* able to cherry-pick rust-lang#87390 as that didn't apply cleanly to the stable branch. `@GuillaumeGomez` `@notriddle` could it be possible to get a PR targeting `stable` backporting that fix?

Also, this **enables** incremental compilation on the stable channel.

r? `@Mark-Simulacrum`
cc `@rust-lang/release`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants