Skip to content

Update Clippy #86782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 135 commits into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
0854f0c
Don't trigger `field_reassign_with_default` in macros
flip1995 May 4, 2021
c64b3ff
Auto merge of #7204 - flip1995:beta_backport, r=flip1995
bors May 10, 2021
7db0e4f
Suggest `&mut iter` inside a closure for `while_let_on_iterator`
Jarcho May 21, 2021
d3c20c8
Some cleanup for use_self
camsteffen May 27, 2021
29b4b4c
Do not lint use_self on type parameters
camsteffen May 27, 2021
6c1ba7c
Fix needless_collect with binding shadowing
camsteffen May 28, 2021
21c829e
Simplify collect expr_ty
camsteffen May 28, 2021
6c27482
Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup
flip1995 Jun 3, 2021
cd57c23
Revert "CI: update rustup before installing the toolchain on windows"
flip1995 Jun 3, 2021
5f746a1
Auto merge of #7314 - flip1995:ci-win-rustup, r=flip1995
bors Jun 3, 2021
2563910
Don't treat `cfg!()` as a constant.
m-ou-se Jun 4, 2021
38ab1a6
Add test for not linting on assert!(cfg!(..)).
m-ou-se Jun 4, 2021
b1752f6
Auto merge of #7319 - m-ou-se:cfg-not-const, r=camsteffen
bors Jun 4, 2021
390893c
Remove `doc(include)`
jyn514 May 19, 2021
dc4ea80
Replace some std::iter::repeat with str::repeat
Jun 4, 2021
52fc18c
Release doc: add explanation for updating the stable branch
flip1995 Jun 4, 2021
9991040
Auto merge of #7289 - camsteffen:needless-collect-shadow, r=Manishearth
bors Jun 4, 2021
b95e1f7
Revert clippy's path to the copy intrinsics (part of reverting PR 812…
pnkfelix Jun 4, 2021
e4a1e85
Auto merge of #7321 - flip1995:doc-release-stable-branch, r=xFrednet
bors Jun 5, 2021
96747c1
Enhance semicolon_if_nothing_returned according to #7324
1c3t3a Jun 5, 2021
790888d
Fixed failing tests
1c3t3a Jun 5, 2021
d7a380e
Fix FP in `default_numeric_fallback` with external macro expansion
Y-Nak Jun 5, 2021
c864e18
Remove some last remants of {push,pop}_unsafe!
syvb May 17, 2021
6bf8303
Refactored the check for two spans on the same line
1c3t3a Jun 7, 2021
967d815
Extracting `is_expr_identity_function` into `clippy_utils` for reusab…
xFrednet Jun 7, 2021
bb3b58c
Reuse `is_expr_identity_function` for `flat_map_identity`
xFrednet Jun 7, 2021
9e54ce8
Reuse `is_expr_identity_function` for `filter_map_identity`
xFrednet Jun 7, 2021
c1577ab
Auto merge of #7325 - Y-Nak:numeric-fallback, r=giraffate
bors Jun 8, 2021
07217e3
Auto merge of #7262 - Jarcho:while_let_on_iter_closure, r=xFrednet,fl…
bors Jun 8, 2021
5336f88
Move `map_identity` into the `methods` module
xFrednet Jun 7, 2021
fe549f7
redundant_clone: fix comment
lengyijun Jun 9, 2021
5ec80f3
Refactored multiline check
1c3t3a Jun 9, 2021
da0538e
Auto merge of #7330 - xFrednet:0000-refactor-map-identity, r=flip1995
bors Jun 9, 2021
dd02468
Auto merge of #7326 - 1c3t3a:1c3t3a-issue-7324, r=flip1995
bors Jun 9, 2021
ea45e2a
Add disallowed_types lint, this adds a field to the Conf struct
DevinR528 Jun 2, 2021
b792bb3
Factor out match_var
camsteffen Jun 9, 2021
0d3f289
Add FreeBSD as identifier not needing ticks
Thomasdezeeuw Jun 9, 2021
2464ee9
Auto merge of #7334 - Thomasdezeeuw:freebsd-no-ticks, r=flip1995
bors Jun 9, 2021
626dc59
Auto merge of #86003 - pnkfelix:issue-84297-revert-81238, r=Mark-Simu…
bors Jun 9, 2021
c4636ab
Auto merge of #7315 - DevinR528:disallowed-ty, r=giraffate
bors Jun 10, 2021
ce7b872
Auto merge of #7332 - lengyijun:redundant_clone_fix, r=giraffate
bors Jun 10, 2021
f7d09b4
Auto merge of #7333 - camsteffen:match-var, r=llogiq
bors Jun 10, 2021
44608b1
added lint to check for full range of vector and suggest append
Valentine-Mario Jun 10, 2021
611b74e
Add support for using qualified paths with structs in expression and …
rylev Dec 10, 2020
f1f5ccd
Auto merge of #7160 - flip1995:field_reassign_macros, r=xFrednet,cams…
bors Jun 11, 2021
70ce0c2
Remove requirement of fully qualified path for disallowed_method/type
DevinR528 Jun 11, 2021
d4eff81
fixup! Remove requirement of fully qualified path for disallowed_meth…
DevinR528 Jun 13, 2021
6379d26
Auto merge of #7288 - camsteffen:use-self2, r=phansch
bors Jun 14, 2021
a36a7c8
Auto merge of #7270 - Valentine-Mario:vec_extend_to_append, r=flip1995
bors Jun 14, 2021
2d1e9ab
Auto merge of #7345 - DevinR528:disallowed-fix, r=Manishearth
bors Jun 14, 2021
fd0ea64
Fix link
Jun 15, 2021
1ee99d9
Auto merge of #7355 - Pyther99:common-tools-link, r=camsteffen
bors Jun 15, 2021
a557f37
Improve metadata code block parsing
camsteffen Jun 14, 2021
7c9da3c
Auto merge of #7352 - camsteffen:metadata-syntax, r=xFrednet
bors Jun 15, 2021
e3eede7
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Jun 17, 2021
a8fd708
Bump nightly version -> 2021-06-17
flip1995 Jun 17, 2021
8302eef
Bump Clippy version -> 0.1.55
flip1995 Jun 17, 2021
f49f1b1
Auto merge of #7364 - flip1995:rustup, r=flip1995
bors Jun 17, 2021
723f515
Add macro_braces lint to check for irregular brace use in certain macros
DevinR528 May 30, 2021
218a609
Update changelog
flip1995 Jun 17, 2021
485747e
Merge remote-tracking branch 'upstream/beta' into backport_remerge
flip1995 Jun 17, 2021
d4f908a
Auto merge of #7367 - flip1995:backport_remerge, r=flip1995
bors Jun 17, 2021
6bf8772
Auto merge of #7366 - flip1995:changelog, r=Manishearth
bors Jun 17, 2021
40fee52
Fix link in changelog
flip1995 Jun 17, 2021
d184413
Auto merge of #7371 - flip1995:changelog, r=flip1995
bors Jun 17, 2021
6e8549e
Make clippy tests happy
0xPoe Jun 18, 2021
e1cc628
Address comment
0xPoe Jun 18, 2021
ebf88c9
Auto merge of #85421 - Smittyvb:rm_pushpop_unsafe, r=matthewjasper
bors Jun 18, 2021
a40fd6d
Move from-iter-instead-of-collect to pedantic
djc Jun 18, 2021
7869e62
Auto merge of #7375 - djc:from-iter-pedantic, r=Manishearth
bors Jun 19, 2021
551931c
Auto merge of #86426 - hi-rustin:rustin-patch-lint-warn, r=Aaron1011
bors Jun 19, 2021
3120b09
Auto merge of #7299 - DevinR528:macro-brace, r=llogiq
bors Jun 19, 2021
d4c9fe7
Improve visibility&helpfulness of the 'found multiple rlibs' error
popzxc Jun 20, 2021
faa2fa7
Improve appearance
popzxc Jun 20, 2021
8276f26
Fix wrong config option being suggested for deprecated wrong_pub_self…
matthiaskrgr Jun 20, 2021
354decc
Auto merge of #85538 - r00ster91:iterrepeat, r=Mark-Simulacrum
bors Jun 20, 2021
96a9786
Fixed broken deploy script due to multiline configuration docs
xFrednet Jun 20, 2021
310a204
Provide different message for bootstrapped compiler
popzxc Jun 21, 2021
d3327bd
Auto merge of #7380 - popzxc:compile-test-helper, r=flip1995
bors Jun 21, 2021
404bd1a
Auto merge of #7382 - matthiaskrgr:config_name, r=flip1995
bors Jun 21, 2021
86bf28d
Auto merge of #7385 - xFrednet:0000-fix-broken-deploy, r=flip1995
bors Jun 21, 2021
dab42cf
Delete spaces
Jun 21, 2021
6e517e9
Rollup merge of #86274 - alexander-melentyev:spaces, r=bjorn3
JohnTitor Jun 21, 2021
206bb08
Remove rustfmt workaround
camsteffen Jun 21, 2021
20cb1bc
check for unbalanced tick pairs in doc-markdown
ebobrow Jun 14, 2021
a8b374f
Auto merge of #7386 - camsteffen:fmt-workaround, r=flip1995
bors Jun 21, 2021
48fa1dc
Auto merge of #7357 - ebobrow:unbalanced-tick, r=xFrednet,flip1995
bors Jun 21, 2021
9301ffb
Update opener.
ehuss Jun 22, 2021
d2087ad
Remove bad cast in test, cover more cases
ranweiler Jun 23, 2021
10122e4
Remove shadowed receiver in check invocation
ranweiler Jun 23, 2021
642239c
Update var name in test
ranweiler Jun 23, 2021
417401f
Auto merge of #7394 - ehuss:update-opener, r=ehuss
bors Jun 23, 2021
d568387
Auto merge of #7396 - ranweiler:zero-offset, r=Manishearth
bors Jun 23, 2021
9492de5
Add import_rename lint, this adds a field on the Conf struct
DevinR528 May 31, 2021
b286b38
Auto merge of #7300 - DevinR528:import-rename, r=camsteffen
bors Jun 24, 2021
0941d9f
Moved dev `ide_setup` to `setup/intellij.rs`
xFrednet Jun 10, 2021
0a5f28c
Added `cargo dev setup git-hook`
xFrednet Jun 10, 2021
41bc0f4
Adjust pre-commit script to readd files after formatting
xFrednet Jun 15, 2021
3d09849
Print cargo dev help on missing arg and updated setup documentation
xFrednet Jun 15, 2021
b48f041
Added the `cargo dev remove` command for convenience
xFrednet Jun 16, 2021
8fdf289
Updated `cargo dev setup intellij` for cleaner user messages
xFrednet Jun 21, 2021
f0fa363
Added `cargo dev remove intellij`
xFrednet Jun 22, 2021
8e969cd
Updated several clippy_dev messages and types (PR suggestions)
xFrednet Jun 23, 2021
a03dfb9
Auto merge of #7361 - xFrednet:5394-expand-setup-command, r=flip1995
bors Jun 25, 2021
39856b1
Improve lint message for match-same-arms lint
popzxc Jun 22, 2021
28d3873
Do not spawn blacklisted_name lint in test context
popzxc Jun 19, 2021
8d427b6
Auto merge of #7379 - popzxc:issue-7305, r=flip1995
bors Jun 25, 2021
abc9a46
Fix clippy test
rylev Jun 25, 2021
7e21db5
Add suspicious group
camsteffen Jun 14, 2021
f02632c
Move some lints to suspicious
camsteffen Jun 14, 2021
5b5f0ea
Add remark-gfm to workflow job
camsteffen Jun 25, 2021
3e59563
Don't use exact definition of std's ErrorKind in test.
m-ou-se Jun 26, 2021
38569c0
Don't suggest unstable and doc(hidden) variants.
m-ou-se Jun 26, 2021
2098b27
Added `cargo dev setup vscode-tasks` for simplicity
xFrednet Jun 27, 2021
e405c68
Auto merge of #7350 - camsteffen:suspicious, r=flip1995
bors Jun 28, 2021
e400191
Updated `clippy_dev` ui message and vscode task name
xFrednet Jun 28, 2021
aa40487
Stabilize `cargo clippy --fix`
jyn514 Jun 26, 2021
f4bc9cf
Auto merge of #7409 - xFrednet:5394-vs-code-tasks, r=giraffate,flip1995
bors Jun 29, 2021
95c2ab7
Auto merge of #7405 - jyn514:fix-stable, r=camsteffen
bors Jun 29, 2021
8827e96
Make ItemKind check dry
camsteffen Jun 17, 2021
4913d82
Simplify in impl check
camsteffen Jun 16, 2021
6e801e2
Use type_of for impl self type
camsteffen Jun 16, 2021
bae76f9
Remove a visitor from use_self
camsteffen Jun 16, 2021
fbd77ef
Auto merge of #7411 - camsteffen:use-self-visitor, r=flip1995
bors Jun 29, 2021
3525a6b
Auto merge of #7390 - popzxc:issue-7331, r=flip1995
bors Jun 30, 2021
018be41
Implement 'disallowed_script_idents' lint
popzxc Jun 30, 2021
cadb93b
Auto merge of #7400 - popzxc:restrict-locales, r=Manishearth
bors Jun 30, 2021
0ffba7a
Simplify wildcard_enum_match_arm test
flip1995 Jul 1, 2021
fae7a09
match_wildcard_for_single_variants: don't produce bad suggestion
flip1995 Jul 1, 2021
753bce3
Auto merge of #7407 - m-ou-se:doc-hidden-variants, r=flip1995
bors Jul 1, 2021
a82a744
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Jul 1, 2021
d446d5e
Bump nightly version -> 2021-07-01
flip1995 Jul 1, 2021
61eb38a
Auto merge of #7418 - flip1995:rustup, r=flip1995
bors Jul 1, 2021
1a385b8
Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup
flip1995 Jul 1, 2021
44cea51
Update Cargo.lock
flip1995 Jul 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions clippy_utils/src/consts.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#![allow(clippy::float_cmp)]

use crate::{clip, sext, unsext};
use crate::{clip, is_direct_expn_of, sext, unsext};
use if_chain::if_chain;
use rustc_ast::ast::{self, LitFloatType, LitKind};
use rustc_data_structures::sync::Lrc;
Expand Down Expand Up @@ -230,7 +230,13 @@ impl<'a, 'tcx> ConstEvalLateContext<'a, 'tcx> {
match e.kind {
ExprKind::Path(ref qpath) => self.fetch_path(qpath, e.hir_id, self.typeck_results.expr_ty(e)),
ExprKind::Block(block, _) => self.block(block),
ExprKind::Lit(ref lit) => Some(lit_to_constant(&lit.node, self.typeck_results.expr_ty_opt(e))),
ExprKind::Lit(ref lit) => {
if is_direct_expn_of(e.span, "cfg").is_some() {
None
} else {
Some(lit_to_constant(&lit.node, self.typeck_results.expr_ty_opt(e)))
}
},
ExprKind::Array(vec) => self.multi(vec).map(Constant::Vec),
ExprKind::Tup(tup) => self.multi(tup).map(Constant::Tuple),
ExprKind::Repeat(value, _) => {
Expand Down
3 changes: 3 additions & 0 deletions tests/ui/assertions_on_constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,7 @@ fn main() {
debug_assert!(false); // #3948
assert_const!(3);
assert_const!(-1);

// Don't lint on this:
assert!(cfg!(feature = "hey") || cfg!(not(feature = "asdf")));
}