Skip to content

Add core to Cargo workspace #86243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Jun 12, 2021

This was breaking completion/IDE support for rust-analyzer in libcore (rust-lang/rust-analyzer#9203). If this is an intentional omission, can we add a comment documenting the reasoning?

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jun 12, 2021

It should already automatically have been automatically added to the cargo workspace because the known member std depends on it, it is located within the workspace directory and it isn't explicitly excluded.

https://doc.rust-lang.org/cargo/reference/workspaces.html?highlight=workspace#the-workspace-section

All path dependencies residing in the workspace directory automatically become members. Additional members can be listed with the members key, which should be an array of strings containing directories with Cargo.toml files.

@lf-
Copy link
Contributor Author

lf- commented Jun 12, 2021

It should already automatically have been automatically added to the cargo workspace because the known member std depends on it, it is located within the workspace directory and it isn't explicitly excluded.

https://doc.rust-lang.org/cargo/reference/workspaces.html?highlight=workspace#the-workspace-section

All path dependencies residing in the workspace directory automatically become members. Additional members can be listed with the members key, which should be an array of strings containing directories with Cargo.toml files.

Ah! This is probably a r-a bug then, and is not on this side then. We should be able to process this case and we aren't doing it yet. I'll just keep this commit around on my end as a workaround until r-a can handle this properly. Closing. Thanks!

@lf- lf- closed this Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants