-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix search results display #85551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 7 commits into
rust-lang:master
from
GuillaumeGomez:fix-search-result-overflow
May 24, 2021
Merged
Fix search results display #85551
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5afa52b
Fix search results display
GuillaumeGomez 221cba3
Implement staggered mobile layout
dns2utf8 d8de2b4
Prepar to remove deep nesting
dns2utf8 ee7cc63
Add padding to mobile layout and fix width issue on both
dns2utf8 0415e0d
Mobile description width: 100%
dns2utf8 c2bd786
Set desc class on the div instead of the span to simplify CSS
GuillaumeGomez 8968c0e
Add test for search result resize width
GuillaumeGomez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
goto: file://|DOC_PATH|/test_docs/index.html | ||
size: (900, 1000) | ||
write: (".search-input", "test") | ||
// Waiting for the search results to appear... | ||
wait-for: "#titles" | ||
// The width is returned by "getComputedStyle" which returns the exact number instead of the | ||
// CSS rule which is "50%"... | ||
assert: (".search-results div.desc", {"width": "320px"}) | ||
size: (600, 100) | ||
// As counter-intuitive as it may seem, in this width, the width is "100%", which is why | ||
// when computed it's larger. | ||
assert: (".search-results div.desc", {"width": "570px"}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.