-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #84966
Closed
Closed
Rollup of 8 pull requests #84966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I came up with this idea ages ago, but rustdoc used to ICE on it. Now it doesn't.
And also add backticks around `MaybeUninit`.
…, r=m-ou-se Stablize {HashMap,BTreeMap}::into_{keys,values} I would propose to stabilize `{HashMap,BTreeMap}::into_{keys,values}`( aka. `map_into_keys_values`). Closes rust-lang#75294.
Simplify chdir implementation and minimize unsafe block
Allow using `core::` in intra-doc links within core itself I came up with this idea ages ago, but rustdoc used to ICE on it. Now it doesn't. Helps with rust-lang#73445. Doesn't fix it completely since `extern crate self as std;` in std still gives strange errors.
Handle incorrect placement of parentheses in trait bounds more gracefully Fix rust-lang#84772. CC ``@jonhoo``
CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs The `copy` name is confusing for this function because we also have `copy_op` which is pretty different. I hope `copy_intrinsic` is clearer. Also `step.rs` should really just contain the main loop and opcode dispatch, so move this helper function to a more appropriate place. r? ``@oli-obk``
…chenkov Only compute Obligation `cache_key` once in `register_obligation_at`
Fix typo in `MaybeUninit::array_assume_init` safety comment And also add backticks around `MaybeUninit`.
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc ``@Aaron1011`` r? ``@jyn514``
@bors: r+ p=8 rollup=never |
📌 Commit 057bb46 has been approved by |
⌛ Testing commit 057bb46 with merge 26ec093d4b79e9d9be9e6ece9bb5719fb4eb3dea... |
💔 Test failed - checks-actions |
Weird... @bors retry |
rolled a bigger rollup because of queue size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::
in intra-doc links within core itself #84755 (Allow usingcore::
in intra-doc links within core itself)cache_key
once inregister_obligation_at
#84923 (Only compute Obligationcache_key
once inregister_obligation_at
)MaybeUninit::array_assume_init
safety comment #84949 (Fix typo inMaybeUninit::array_assume_init
safety comment)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup