Skip to content

Rework SESSION_GLOBALS API #84961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Rework SESSION_GLOBALS API #84961

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2654fb
Rework SESSION_GLOBALS API to prevent overwriting it
GuillaumeGomez May 5, 2021
d891c8c
Update to last upstream version
GuillaumeGomez Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update to last upstream version
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Jul 8, 2021
commit d891c8cd544e7f01dba2163cd1016ddf90dfedaf
10 changes: 6 additions & 4 deletions compiler/rustc_lint/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
use crate::context::parse_lint_and_tool_name;
use rustc_span::{with_default_session_globals, Symbol};
use rustc_span::{create_default_session_globals_then, Symbol};

#[test]
fn parse_lint_no_tool() {
with_default_session_globals(|| assert_eq!(parse_lint_and_tool_name("foo"), (None, "foo")));
create_default_session_globals_then(|| {
assert_eq!(parse_lint_and_tool_name("foo"), (None, "foo"))
});
}

#[test]
fn parse_lint_with_tool() {
with_default_session_globals(|| {
create_default_session_globals_then(|| {
assert_eq!(parse_lint_and_tool_name("clippy::foo"), (Some(Symbol::intern("clippy")), "foo"))
});
}

#[test]
fn parse_lint_multiple_path() {
with_default_session_globals(|| {
create_default_session_globals_then(|| {
assert_eq!(
parse_lint_and_tool_name("clippy::foo::bar"),
(Some(Symbol::intern("clippy")), "foo::bar")
Expand Down