Add `FromIterator` and `IntoIterator` impls for `ThinVec` by camelid · Pull Request #83821 · rust-lang/rust

camelid · 2021-04-03T19:22:53Z

These should make using ThinVec feel much more like using Vec.
They will allow users of Vec to switch to ThinVec while continuing
to use collect(), for loops, and other parts of the iterator API.

I don't know if there were use cases before for using the iterator API
with ThinVec, but I would like to start using ThinVec in rustdoc,
and having it conform to the iterator API would make the transition
a lot easier.

I added a FromIterator impl, an IntoIterator impl that yields owned
elements, and IntoIterator impls that yield immutable or mutable
references to elements. I also added some unit tests for ThinVec.

rust-highfive · 2021-04-03T19:22:55Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

compiler/rustc_data_structures/src/thin_vec.rs

camelid · 2021-04-03T20:22:07Z

Do you think it's worth adding a len() method too?

camelid · 2021-04-03T20:29:51Z

Inference was struggling in the FromIterator test with the into(), so I added a to_vec() method that is private to the tests module. Do you want me to add that to the public API?

compiler/rustc_data_structures/src/thin_vec.rs

petrochenkov · 2021-04-03T23:22:46Z

Do you think it's worth adding a len() method too?

I wouldn't personally add methods that are not used right now, if they can always be added on demand.
If the upcoming rustdoc changes use it, then it's worth adding.

camelid · 2021-04-04T17:44:09Z

Let me know before you r+ and I can squash.

compiler/rustc_data_structures/src/thin_vec.rs

petrochenkov · 2021-04-05T10:59:08Z

r=me with commits squashed.

jyn514 · 2021-04-05T16:02:25Z

compiler/rustc_data_structures/src/thin_vec.rs

It looks like this is also missing .push and .pop, I can add those separately. Seems weird that this derefs to a slice instead of a vec.

You couldn't DerefMut to a vec in the None case.

These should make using `ThinVec` feel much more like using `Vec`. They will allow users of `Vec` to switch to `ThinVec` while continuing to use `collect()`, `for` loops, and other parts of the iterator API. I don't know if there were use cases before for using the iterator API with `ThinVec`, but I would like to start using `ThinVec` in rustdoc, and having it conform to the iterator API would make the transition *a lot* easier. I added a `FromIterator` impl, an `IntoIterator` impl that yields owned elements, and `IntoIterator` impls that yield immutable or mutable references to elements. I also added some unit tests for `ThinVec`.

camelid · 2021-04-06T02:11:51Z

@bors r=petrochenkov

bors · 2021-04-06T02:11:52Z

📌 Commit 09ff88b has been approved by petrochenkov

bors · 2021-04-06T09:57:17Z

⌛ Testing commit 09ff88b with merge e1d49aa...

bors · 2021-04-06T12:20:43Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing e1d49aa to master...

camelid added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2021

rust-highfive assigned petrochenkov Apr 3, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2021

This comment has been minimized.

Sign in to view

camelid force-pushed the improve-thinvec branch from 0fdc4e3 to 645c723 Compare April 3, 2021 19:56

petrochenkov reviewed Apr 3, 2021

View reviewed changes

compiler/rustc_data_structures/src/thin_vec.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021

This comment has been minimized.

Sign in to view

camelid force-pushed the improve-thinvec branch from 645c723 to fb4e62b Compare April 3, 2021 20:06

This comment has been minimized.

Sign in to view

camelid force-pushed the improve-thinvec branch from fb4e62b to 4985ee6 Compare April 3, 2021 20:17

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2021

camelid force-pushed the improve-thinvec branch from 4985ee6 to fbfee02 Compare April 3, 2021 20:29

This comment has been minimized.

Sign in to view

cjgillot reviewed Apr 3, 2021

View reviewed changes

compiler/rustc_data_structures/src/thin_vec.rs Outdated Show resolved Hide resolved

camelid force-pushed the improve-thinvec branch from fbfee02 to 08f2bfe Compare April 3, 2021 21:08

camelid mentioned this pull request Apr 3, 2021

rustdoc: Use ThinVec in a few places #83828

Merged

petrochenkov reviewed Apr 3, 2021

View reviewed changes

compiler/rustc_data_structures/src/thin_vec.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2021

jyn514 reviewed Apr 4, 2021

View reviewed changes

compiler/rustc_data_structures/src/thin_vec.rs Outdated Show resolved Hide resolved

the8472 reviewed Apr 4, 2021

View reviewed changes

compiler/rustc_data_structures/src/thin_vec.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

camelid force-pushed the improve-thinvec branch from 6458349 to cc7b947 Compare April 4, 2021 22:54

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2021

jyn514 reviewed Apr 5, 2021

View reviewed changes

jyn514 mentioned this pull request Apr 5, 2021

rustdoc: Store intra-doc links in Cache instead of on items directly #83833

Merged

camelid force-pushed the improve-thinvec branch from cc7b947 to 09ff88b Compare April 6, 2021 02:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 6, 2021

bors merged commit e1d49aa into rust-lang:master Apr 6, 2021

rustbot added this to the 1.53.0 milestone Apr 6, 2021

camelid deleted the improve-thinvec branch April 6, 2021 16:51

Uh oh!

Comments

Conversation

camelid commented Apr 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Apr 3, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

camelid commented Apr 3, 2021

Uh oh!

camelid commented Apr 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

petrochenkov commented Apr 3, 2021

Uh oh!

camelid commented Apr 4, 2021

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

petrochenkov commented Apr 5, 2021

Uh oh!

jyn514 Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

the8472 Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

camelid commented Apr 6, 2021

Uh oh!

bors commented Apr 6, 2021

Uh oh!

bors commented Apr 6, 2021

Uh oh!

bors commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

camelid commented Apr 3, 2021 •

edited

Loading

camelid commented Apr 3, 2021 •

edited

Loading